-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3단계 - 기능 우선 패키지 구성하기 #493
base: dongock
Are you sure you want to change the base?
3단계 - 기능 우선 패키지 구성하기 #493
Changes from all commits
baf77e5
1400ef8
c01d4a5
4294850
c8d4692
685b015
a11adeb
80fce88
2872bd4
f639527
f3f859d
fef56bf
baa401d
8b6166d
d4137f2
35162e9
86256a6
3de9bbf
b98fa4a
bf12cff
9214a45
ef46a24
3464a7d
234ae23
0b08f06
d0d6985
dc5465d
4b3964b
4919f92
e620709
b6c4c73
ae1b351
cc399ce
59b8ba3
a58fd5c
4f1f640
a0bc547
eb4ea3a
183e912
0de0156
144f902
f9c2af2
14408dc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
package kitchenpos.domain; | ||
package kitchenpos.order.common.domain.model; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 공통영역에 주문 엔티티를 구성해주신 의도가 궁금해요 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 맨처음에 나누면서는 온전히 생각을 못했어서 공통을 두고 전체적으로 커버할 수 있는 영역을 만들자라고 생각했는데, 다시 생각해보니 제가 분리를 진행하면서 온전히 다 처리할 수 있을거 같네요. 없애도 될 거 같아요. 감사합니다 ㅎㅎ |
||
|
||
import jakarta.persistence.CascadeType; | ||
import jakarta.persistence.Column; | ||
|
@@ -12,6 +12,9 @@ | |
import jakarta.persistence.OneToMany; | ||
import jakarta.persistence.Table; | ||
import jakarta.persistence.Transient; | ||
import kitchenpos.order.common.domain.OrderStatus; | ||
import kitchenpos.order.common.domain.OrderType; | ||
import kitchenpos.order.eatinorder.domain.model.OrderTable; | ||
|
||
import java.time.LocalDateTime; | ||
import java.util.List; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OrderService 도 공통에 위치한 의도가 궁금해요 🤔
각각의 컨텍스트로 분리해주셨는데 어떤 역할로 위치해주신 것일까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
위랑 같은 생각이었습니다 ㅎㅎ