Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸš€ 3단계 - κΈ°λŠ₯ μš°μ„  νŒ¨ν‚€μ§€ κ΅¬μ„±ν•˜κΈ° #332

Open
wants to merge 1 commit into
base: jordy-torvalds
Choose a base branch
from

Conversation

jordy-torvalds
Copy link

No description provided.

@jordy-torvalds jordy-torvalds changed the title Step3 πŸš€ 3단계 - κΈ°λŠ₯ μš°μ„  νŒ¨ν‚€μ§€ κ΅¬μ„±ν•˜κΈ° Sep 12, 2023
Copy link

@hyunssooo hyunssooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ•ˆλ…•ν•˜μ„Έμš”.
κΈ°λŠ₯ μš°μ„  νŒ¨ν‚€μ§€ κ΅¬μ„±ν•˜κΈ° 잘 진행해 μ£Όμ…¨μŠ΅λ‹ˆλ‹€.
κ°€λ²Όμš΄ μ½”λ©˜νŠΈ λ‚¨κ²ΌλŠ”λ°μš”. 확인 λΆ€νƒλ“œλ¦΄κ²Œμš”.
λ‹€μŒ μš”μ²­μ—λŠ” λ¨Έμ§€ν•˜λ„λ‘ ν•˜κ² μŠ΅λ‹ˆλ‹€. πŸ™‚

Comment on lines +1 to 2
package kitchenpos.common.infra;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.
β”œβ”€β”€ Application.java
β”œβ”€β”€ common
β”‚Β Β  └── infra
β”‚Β Β      β”œβ”€β”€ DefaultPurgomalumClient.java
β”‚Β Β      └── PurgomalumClient.java
β”œβ”€β”€ delivery
β”‚Β Β  └── infra
β”‚Β Β      β”œβ”€β”€ DefaultKitchenridersClient.java
β”‚Β Β      └── KitchenridersClient.java
β”œβ”€β”€ menu
β”‚Β Β  β”œβ”€β”€ api
β”‚Β Β  β”‚Β Β  └── MenuRestController.java
β”‚Β Β  β”œβ”€β”€ application
β”‚Β Β  β”‚Β Β  └── MenuService.java
β”‚Β Β  β”œβ”€β”€ domain
β”‚Β Β  β”‚Β Β  β”œβ”€β”€ Menu.java
β”‚Β Β  β”‚Β Β  β”œβ”€β”€ MenuProduct.java
β”‚Β Β  β”‚Β Β  └── MenuRepository.java
β”‚Β Β  └── infra
β”‚Β Β      └── JpaMenuRepository.java
β”œβ”€β”€ menugroup
β”‚Β Β  β”œβ”€β”€ api
β”‚Β Β  β”‚Β Β  └── MenuGroupRestController.java
β”‚Β Β  β”œβ”€β”€ application
β”‚Β Β  β”‚Β Β  └── MenuGroupService.java
β”‚Β Β  β”œβ”€β”€ domain
β”‚Β Β  β”‚Β Β  β”œβ”€β”€ MenuGroup.java
β”‚Β Β  β”‚Β Β  └── MenuGroupRepository.java
β”‚Β Β  └── infra
β”‚Β Β      └── JpaMenuGroupRepository.java
β”œβ”€β”€ order
β”‚Β Β  β”œβ”€β”€ api
β”‚Β Β  β”‚Β Β  └── OrderRestController.java
β”‚Β Β  β”œβ”€β”€ application
β”‚Β Β  β”‚Β Β  └── OrderService.java
β”‚Β Β  β”œβ”€β”€ domain
β”‚Β Β  β”‚Β Β  β”œβ”€β”€ Order.java
β”‚Β Β  β”‚Β Β  β”œβ”€β”€ OrderLineItem.java
β”‚Β Β  β”‚Β Β  β”œβ”€β”€ OrderRepository.java
β”‚Β Β  β”‚Β Β  β”œβ”€β”€ OrderStatus.java
β”‚Β Β  β”‚Β Β  └── OrderType.java
β”‚Β Β  └── infra
β”‚Β Β      └── JpaOrderRepository.java
β”œβ”€β”€ ordertable
β”‚Β Β  β”œβ”€β”€ api
β”‚Β Β  β”‚Β Β  └── OrderTableRestController.java
β”‚Β Β  β”œβ”€β”€ application
β”‚Β Β  β”‚Β Β  └── OrderTableService.java
β”‚Β Β  β”œβ”€β”€ domain
β”‚Β Β  β”‚Β Β  β”œβ”€β”€ OrderTable.java
β”‚Β Β  β”‚Β Β  └── OrderTableRepository.java
β”‚Β Β  └── infra
β”‚Β Β      └── JpaOrderTableRepository.java
└── product
    β”œβ”€β”€ api
    β”‚Β Β  └── ProductRestController.java
    β”œβ”€β”€ application
    β”‚Β Β  └── ProductService.java
    β”œβ”€β”€ domain
    β”‚Β Β  β”œβ”€β”€ Product.java
    β”‚Β Β  └── ProductRepository.java
    └── infra
        └── JpaProductRepository.java

μ „μ²΄μ μœΌλ‘œ 잘 λ‚˜λˆ μ£Όμ…¨μŠ΅λ‹ˆλ‹€. :)

ν˜„μž¬ Order BCκ°€ ν•˜λ‚˜λ‘œ 합쳐져 μžˆλŠ”λ°μš”. λ‚˜λˆ λ³΄λŠ” 것도 κ³ λ €ν•΄ λ³΄μ‹œλ©΄ 쒋을 것 κ°™μŠ΅λ‹ˆλ‹€.
개인적으둜 생각해 λ΄€λŠ”λ°μš”. λ‚˜λˆ΄μ„ λ•Œ κ³ λ €ν•΄ λ³Ό 뢀뢄은 μ€‘λ³΅λ˜λŠ” 뢀뢄듀은 μ–΄λ–»κ²Œ ν•  것인가? 일 것 κ°™μ•„μš”.

  • OrderType이 ν•„μš”ν•œκ°€?
    • 클래슀λͺ…μœΌλ‘œ ν‘œν˜„ κ°€λŠ₯ν•˜μ§€ μ•Šμ„κΉŒ? EatinOrder DeliveryOrder TakeoutOrder
  • ν•˜λ‚˜μ˜ OrderStatus둜 각 주문의 μƒνƒœλ“€μ„ νŒŒμ•…ν•  수 μžˆμ„κΉŒ?
  • RepositoryλŠ” Aggregate ν•˜λ‚˜μ΄λ‹ˆ λ‚˜λˆ μ§€λŠ” 것이 λ§žμ§€ μ•Šμ„κΉŒ?
  • OrderServiceλŠ” 각 μ£Όλ¬Έλ§ˆλ‹€ usecaseκ°€ λ‹€λ₯΄λ‹ˆ λ‚˜λˆ μ§€λŠ” 것이 관리 μΈ‘λ©΄μ—μ„œ 쒋지 μ•Šμ„κΉŒ?

μ •λ„λ‘œ κ³ λ―Όν•΄ λ΄€μ–΄μš”.

  1. KitchenridersClient λŠ” delivery둜 λ‚˜λˆ μ Έ μžˆλŠ”λ°μš”. Orderλž‘ 합쳐볼 수 도 μžˆμ§€ μ•Šμ„κΉŒμš”?
  • deliveryOrder μ—μ„œλ§Œ μ‚¬μš©ν•΄μ„œμš”.
  1. menu, menugroup이 λ³„λ„μ˜ BC둜 λ‚˜λˆ„μ‹  μ›μ‹λ‹˜ 생각을 듀어보고 μ‹Άμ–΄μš”. πŸ™‚
  2. order, ordertabler 도 λ³„λ„μ˜ BC라고 봐주신 κ±ΈκΉŒμš”?

μ›μ‹λ‹˜λ„ ν”Όλ“œλ°± ν•œλ²ˆ μ£Όμ‹œλ©΄ 쒋을 것 κ°™μŠ΅λ‹ˆλ‹€. πŸ™‚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants