feat(TMG-2609): Update web implementation for commenting entitlement #4029
Conversation
sauravarora04
force-pushed
the
feat/TMG-2609-commenting-entitlement-3
branch
from
bb5fa1c to
fef9c66
Compare
Extracreative
force-pushed
the
feat/TMG-2609-commenting-entitlement-3
branch
from
fef9c66 to
6d774dd
Compare
sauravarora04
force-pushed
the
feat/TMG-2609-commenting-entitlement-3
branch
from
6d774dd to
e0292b5
Compare
| if (!isEnabled && !isCommentEnabled) { | ||
| content = <DisabledComments />; | ||
| } else if (hasCommentingEntitlement) { | ||
| content = ( |
There was a problem hiding this comment.
Why not just use conditional rendering? This pattern is... unusual
There was a problem hiding this comment.
The purpose of this pattern was to wrap different condition results within a user state wrapper.
There was a problem hiding this comment.
What are the benefits of using the user state wrapper versus conditional rendering?
There was a problem hiding this comment.
So, the user-state component is dealing with all user states (like hasAccess, isLoggedin, etc.). I've just tried to re-use the existing pattern.
sauravarora04
force-pushed
the
feat/TMG-2609-commenting-entitlement-3
branch
from
871f42a to
4c26b28
Compare
sauravarora04
changed the title
sauravarora04
changed the title
| @@ -110,7 +110,7 @@ jobs: | |||
| - run: | |||
| name: Run Web Tests | |||
| command: | | |||
| lerna run test:web --stream --since -- -- --ci --bail --coverage | |||
| lerna run test:web --since -- -- --ci --coverage --verbose --runInBand --logHeapUsage | |||
There was a problem hiding this comment.
So runInBand will probably help with memory usage, but it should also mean the tests run slower. Was this a required change?
sauravarora04
force-pushed
the
feat/TMG-2609-commenting-entitlement-3
branch
2 times, most recently
from
8028854 to
a92a80c
Compare
sauravarora04
force-pushed
the
feat/TMG-2609-commenting-entitlement-3
branch
from
855317e to
7753887
Compare
|
Description
Please include a summary of the change along with relevant motivation and context.
JIRA-1234
Checklist
Screenshots (if appropriate):
Include screenshots if needed.