Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/tmpz 776 create user feedback box #4016

Open
wants to merge 74 commits into
base: master
Choose a base branch
from

Conversation

josipVuko
Copy link
Contributor

@josipVuko josipVuko commented Dec 20, 2024

Description

Created sticky note for feedback box for audio player

TMPZ-776

Checklist

  • Have you done any manual testing?
  • Does it have automated tests?
  • Do you need any other PRs merged before this (if so please list)?
  • Do you need to update the README/Runbook
  • Have you checked for accessibility?

Screenshots (if appropriate):

Include screenshots if needed.

dbuljanNewsUk and others added 30 commits November 15, 2024 12:37
@josipVuko josipVuko requested a review from a team as a code owner December 20, 2024 10:55
@@ -247,6 +247,11 @@ function SaveAndShareBar(props) {
)}
</>
) : null}
{process.env.NODE_ENV !== "test" && (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also add a boolean here for audioEnabled and have it's default as false, and then in the tests and showcase we can enable it by setting it to true, much like we do with the savingEnabled or sharingEnabled ?

Copy link

sonarqubecloud bot commented Jan 8, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
15.7% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants