Remove lodash & fix all lint issues

newsuk · Jan 28, 2025 · 4487c49 · 4487c49
1 parent 3fceef6
commit 4487c49
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 17 deletions.
diff --git a/packages/ssr/package.json b/packages/ssr/package.json
@@ -68,7 +68,6 @@
     "apollo-link-persisted-queries": "0.2.2",
     "cypress": "^13.14.0",
     "cypress-wait-until": "1.7.2",
-    "lodash": "4.17.21",
     "node-fetch": "2.6.7",
     "react": "16.9.0",
     "react-apollo": "2.5.5",

diff --git a/packages/ssr/src/lib/affiliate-links-validation.js b/packages/ssr/src/lib/affiliate-links-validation.js
@@ -2,15 +2,8 @@ const { wrapSkimlinks } = require("./skimlinks-wrapping");
 const { wrapTrackonomics } = require("../lib/trackonomics-wrapping");
 
 const wrapAffiliateLink = (affiliateLink, contentPageUrl) => {
-  console.log("affiliateLink: ", wrapSkimlinks(affiliateLink, contentPageUrl));
-  console.log("contentPageUrl: ", contentPageUrl);
-  console.log("skimlinksLink: ", wrapSkimlinks(affiliateLink, contentPageUrl));
-
   const skimlinksUrl = wrapSkimlinks(affiliateLink, contentPageUrl);
-  console.log(
-    "trackonomicsUrl: ",
-    wrapTrackonomics(affiliateLink, skimlinksUrl, contentPageUrl)
-  );
+
   return wrapTrackonomics(affiliateLink, skimlinksUrl, contentPageUrl);
 };
 

diff --git a/packages/ssr/src/lib/skimlinks-wrapping.js b/packages/ssr/src/lib/skimlinks-wrapping.js
@@ -35,10 +35,7 @@ const constructSkimlinksUrl = (merchantUrl, contentPageUrl) => {
   return skimlinksWrapper;
 };
 
-const wrapSkimlinks = (url, contentPageUrl) => {
-  return urlContainsDomain(url)
-    ? constructSkimlinksUrl(url, contentPageUrl)
-    : url;
-};
+const wrapSkimlinks = (url, contentPageUrl) =>
+  urlContainsDomain(url) ? constructSkimlinksUrl(url, contentPageUrl) : url;
 
 module.exports = { wrapSkimlinks };
diff --git a/packages/ssr/src/lib/trackonomics-wrapping.js b/packages/ssr/src/lib/trackonomics-wrapping.js
@@ -24,10 +24,9 @@ const constructTrackonomicsUrl = (trackonomicsUrl, contentPageUrl) => {
   return trackonomicsWrapper;
 };
 
-const wrapTrackonomics = (url, trackonomicsUrl, contentPageUrl) => {
-  return isTrackonomicsUrl(url)
+const wrapTrackonomics = (url, trackonomicsUrl, contentPageUrl) =>
+  isTrackonomicsUrl(url)
     ? constructTrackonomicsUrl(trackonomicsUrl, contentPageUrl)
     : trackonomicsUrl;
-};
 
 module.exports = { wrapTrackonomics };