Skip to content

test: run doctests #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025
Merged

test: run doctests #17

merged 1 commit into from
May 15, 2025

Conversation

DavSanchez
Copy link
Contributor

@DavSanchez DavSanchez commented May 15, 2025

The pipelines for testing the project were calling cargo test --all-targets --verbose which excludes doctests. This PR adds an additional line to run any existing doc tests and fixed some of the documented Rust code so it doesn't run since it wouldn't compile on its own.

@DavSanchez DavSanchez requested a review from a team as a code owner May 15, 2025 12:40
@sigilioso
Copy link
Contributor

No description provided
😢 😉

Copy link
Contributor

@sigilioso sigilioso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -43,6 +43,7 @@ jobs:
rustup default ${{ matrix.toolchain }}
- run: cargo build --verbose
- run: cargo test --all-targets --verbose
- run: cargo test --doc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the line above doesn't run them automatically because of rust-lang/cargo#6669, good to know!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for linking that issue! Wasn't aware it existed.

@DavSanchez
Copy link
Contributor Author

No description provided

😢 😉

Added, thanks!

@DavSanchez DavSanchez merged commit ac32084 into main May 15, 2025
13 checks passed
@DavSanchez DavSanchez deleted the test/doctests branch May 15, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants