-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: kiosk entity (Staging) #1975
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beep boop bop.
I have found some errors processing these changes:
* Error VALIDATING domainType: 'EXT-KIOSK' on Summary metrics for key ''memoryUsage': wrong golden metric reference. Couldn't find a golden metric definition with key 'MemoryUsage', please populate 'goldenMetric' with a valid reference to an existing golden metric.' - Exception: 'memoryUsage': wrong golden metric reference. Couldn't find a golden metric definition with key 'MemoryUsage', please populate 'goldenMetric' with a valid reference to an existing golden metric.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beep boop bop.
I have found some errors processing these changes:
* Error VALIDATING domainType: 'EXT-KIOSK' on Summary metrics for key ''memoryUsage': wrong golden metric reference. Couldn't find a golden metric definition with key 'MemoryUsage', please populate 'goldenMetric' with a valid reference to an existing golden metric.' - Exception: 'memoryUsage': wrong golden metric reference. Couldn't find a golden metric definition with key 'MemoryUsage', please populate 'goldenMetric' with a valid reference to an existing golden metric.
Hey @naxhh not sure what this error is about the output doesn't provide any direction unfortunately. If I validate locally the output looks okay, there is only errors about other definitions.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Remember this is intended to be on staging for testing ony
# template: dashboard.json | ||
configuration: | ||
# enable only when things are confirmed so we can at least release the old entities whilst testing | ||
# entityExpirationTime: EIGHT_DAYS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TTL is required when using synthesis so even if not provided it will default to 8 days.
"width": 4, | ||
"height": 3 | ||
}, | ||
"linkedEntityGuids": null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Kav91 ! Can you remove this line please? Seems it is the cause of the sanitize-dashboards
check failing.
Intended for STAGING only at this point for testing.
As per internal discussions around point of sales systems cc/ @naxhh .
Initial definition for a kiosk.
Example payload structure:
Checklist
identifier
will be unique and valid.