Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ext IBM iSeries Definition. #1892

Closed
wants to merge 4 commits into from

Conversation

LouwMarais
Copy link

Relevant information

Added a new External IBM iSeries entity definition with the main goal being that our custom insights metric generated with an attribute of includeInIseriesEntity should be used to automatically create our IBM iSeries as an Entity and visible on distributed tracing maps

Checklist

  • I've read the guidelines and understand the acceptance criteria.
  • The value of the attribute marked as identifier will be unique and valid.
  • I've confirmed that my entity type wasn't already defined. If it is I'm providing an explanation above.

github-actions[bot]
github-actions bot previously approved these changes Feb 3, 2025
@CLAassistant
Copy link

CLAassistant commented Feb 3, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ LouwMarais
❌ jmarais


jmarais seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@LouwMarais
Copy link
Author

I am going to have to start this pull request over. somehow got my wrong username on the commit and cannot do the CLA

@LouwMarais LouwMarais closed this Feb 3, 2025
@LouwMarais LouwMarais deleted the add-ibm-iseries branch February 3, 2025 22:15
@LouwMarais
Copy link
Author

updated pr is here: #1895

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants