Fixes for #479, #480, #481 #486
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rust Logger OSL Merge
…ging Fixes #480 Also fixes a bug inside update_log_configuration which only moves the log file, and not the .json file.
Member
|
Hey @unshrawal, sorry for the delay! Can you try resolving the conflicts? They probably occurred due to some recent changes to the library over the last month. |
Member
|
Hey @unshrawal can you remind me of the status of this? Are we just waiting for conflicts to be resolved? |
Contributor
Author
|
Hey @tkevinbest, I think the only thing that's left is resolving the merge conflicts - unless y'all have found any more bugs within the new logger. I'll try to fix all of the merge conflict by the end of this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#481 - This PR flattens the current JSON schema so that all values are logged under the "attributes" key instead of grouping values differently for variables and functions.
#480 - This PR fixes the current use of a hardcoded "variables.log" string, and instead uses the user-given string for the log file and uses this name for the JSON data file.
#479 - Currently, we set up the user-configured file at initialization. This is a problem in the open-source leg library, since we initialize a global logger, and the user might change their logging configuration, which can lead to empty and unused files. This PR fixes this by lazily creating the files.