Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Make first release #76

Merged
merged 1 commit into from
Aug 7, 2024
Merged

[CI] Make first release #76

merged 1 commit into from
Aug 7, 2024

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Aug 7, 2024

Release Notes

First release of the Neurobagel deployment recipe. This release introduces different deployment profiles and an automated process for setting up a graph store using Docker Compose, as well as various environment variables for configuring the behaviour of Neurobagel services using a single .env file.

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@alyssadai alyssadai added the release Create a release when this PR is merged label Aug 7, 2024
@alyssadai alyssadai requested review from rmanaem and removed request for rmanaem August 7, 2024 19:37
@surchs surchs self-requested a review August 7, 2024 20:01
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

release away 🧑‍🍳

Side questions:

  • do we want to use CI as the PR name for this or make a new RL release one?
  • making an extra issue and an extra PR per release seems like a lot of overhead, do we need to / want to keep doing that as opposed to just releasing off of the most recent feature/non-zero-diff PR?

@alyssadai
Copy link
Contributor Author

alyssadai commented Aug 7, 2024

@surchs,

making an extra issue and an extra PR per release seems like a lot of overhead, do we need to / want to keep doing that as opposed to just releasing off of the most recent feature/non-zero-diff PR?

I actually think we want to avoid this generally, and release off of a non-zero-diff PR whenever possible. In this case, it was necessary to make a new PR to trigger the release process with the release label, because we have:

"onlyPublishWithReleaseLabel": true,

and there weren't any other open PRs or quick-fix issues that I could attach the release to.

For the same reason,

do we want to use CI as the PR name for this or make a new RL release one?

I don't think so, because we want to discourage doing that.

@alyssadai alyssadai merged commit 62827cc into main Aug 7, 2024
2 checks passed
@alyssadai alyssadai deleted the release-recipes branch August 7, 2024 20:11
Copy link
Contributor

neurobagel-bot bot commented Aug 7, 2024

🚀 PR was released in v0.0.1 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Create a release when this PR is merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make first release of recipes
2 participants