-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add variables for API root paths + query site header script, add default values #106
Conversation
@surchs, this PR is also ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good. I left a couple of suggestions. I think the main thing is whether we rename the env variables on the tools to match the names we use in the recipe. I think that'd help quite a bit to avoid confusion.
🧑🍳
Co-authored-by: Sebastian Urchs <[email protected]>
🚀 PR was released in |
Changes proposed in this pull request:
NB_NAPI_BASE_PATH
,NB_FAPI_BASE_PATH
,NB_QUERY_HEADER_SCRIPT
docker-compose.yml
Housekeeping:
NB_MIN_CELL_SIZE
in docker-compose.yml, related to [ENH] AddNB_MIN_CELL_SIZE
env var & reorder env var table for better flow #98Checklist
This section is for the PR reviewer
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
,[MODEL]
,[DOC]
) (see our Contributing Guidelines for more info)skip-release
(to be applied by maintainers only)Closes #XXXX
For new features:
For bug fixes: