Skip to content
This repository has been archived by the owner on Mar 9, 2024. It is now read-only.

[ENH] Implemented tooltips for download results buttons #160

Merged
merged 4 commits into from
Jul 18, 2023
Merged

Conversation

rmanaem
Copy link
Collaborator

@rmanaem rmanaem commented Jul 18, 2023

Closes #128

Changes proposed in this pull request:

  • Implemented tooltips for download results buttons
  • Implemented test for the tooltips

Checklist

  • PR has an interpretable title with a prefix ([ENH], [BUG], [DOC], [INFRA], [MAINT])
  • PR links to Github issue with mention Closes #XXXX
  • Tests pass
  • Code is properly formatted

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@netlify
Copy link

netlify bot commented Jul 18, 2023

Deploy Preview for neurobagel-query-tool ready!

Name Link
🔨 Latest commit bfc9ba9
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-query-tool/deploys/64b6a04f34c0c000082b6c52
😎 Deploy Preview https://deploy-preview-160--neurobagel-query-tool.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@surchs surchs self-requested a review July 18, 2023 14:35
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool @rmanaem 🎉! Works like a charm, ready to go 🧑‍🍳

One comment: as great as the staging-preview is, for features like this one it is pretty useless until we find a way to have the query tool default to some test api that it can actually query. at the moment I can only test this by locally checking this out.

@rmanaem rmanaem merged commit 3cf84ea into main Jul 18, 2023
@rmanaem rmanaem deleted the feat-128 branch August 1, 2023 16:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make requirement of selecting datasets for download more apparent
2 participants