-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Update reverse proxy recipe with nginx conf #254
Conversation
To have longer request timeouts
✅ Deploy Preview for neurobagel-documentation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @surchs! One question about the way we're mounting the custom nginx config file - maybe you can take a quick look in case I'm misunderstanding something
Co-authored-by: Alyssa Dai <[email protected]>
|
Turns out this was not a typo... This reverts commit 1d47915.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @surchs, this LGTG 🧑🍳
Re: Docker bind mounting of files, the closest documentation of our observed behaviour I could find was https://docs.docker.com/engine/storage/bind-mounts/#considerations-and-constraints
Bind mounts have write access to files on the host by default.
One side effect of using bind mounts is that you can change the host filesystem via processes running in a container, including creating, modifying, or deleting important system files or directories. This capability can have security implications. For example, it may affect non-Docker processes on the host system.
You can use the readonly or ro option to prevent the container from writing to the mount.
From what I understand, it is expected that when you bind-mount a file into a container, the mounted file's parent directory is effectively exposed within the container. So if the container writes to the parent directory, those changes are reflected on the host (unless we add the ro
option).
To have longer request timeouts
Changes proposed in this pull request:
Checklist
Please leave checkboxes empty for PR reviewers
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
) see our Contributing Guidelines for more info)Closes #XXXX