-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add docker image build for arm64 architecture #429
base: main
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis PR updates the docker build workflow to support ARM64 architecture alongside AMD64. The changes are implemented by modifying the build configuration, adding platform specifications for the docker build, and including a testing step that runs the CLI help command on the built image. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #429 +/- ##
=======================================
Coverage 98.55% 98.55%
=======================================
Files 18 18
Lines 1109 1109
=======================================
Hits 1093 1093
Misses 16 16 ☔ View full report in Codecov by Sentry. |
Changes proposed in this pull request:
note: we confirmed that the new arm images are runnable on an arm mac by pulling, running and getting the help menu to show.
Checklist
This section is for the PR reviewer
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
,[MODEL]
,[DOC]
) (see our Contributing Guidelines for more info)skip-release
(to be applied by maintainers only)Closes #XXXX
For new features:
For bug fixes:
Summary by Sourcery
Enable building and pushing of CLI Docker images for both arm64 and amd64 architectures in the CI workflow, and add a verification step to ensure the image runs correctly.
Build:
CI: