-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn generate_neurobagel_example_jsonlds.sh
into makefile
#412
Comments
Hey @surchs, following up on this issue - I think the original context for this suggestion was to automate the following steps which are currently needed before you can run the script:
However, as mentioned today, I think these operations could be integrated into the same existing shell script rather than moving to a Wdyt? |
Hey @alyssadai, that sounds good to me! |
The script operations may be better handled with a makefile. Mainly because you have to make sure that the script is being run only from the repo root dir (and a bunch of other stuff is also needed). But we're all human, so we might run it from the wrong dir, and then the docker commands are going to create a bunch of root-ownder folders in the repo - which is annoying.
makefile would make this all a lot easier. And it could also do the submodule getting / branching and so on for you. So I suggest we do that. If this is too big a move, let's split this off into its own PR
Also, we should simplify the internal mountpoint from
/data/neurobagel/bagel-cli
to/data
.Originally posted by @surchs in #410 (comment)
The text was updated successfully, but these errors were encountered: