Adding HistogramObserver #2049
Open
Adding HistogramObserver #2049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinavnmagic
requested review from
a team,
shubhra,
DaltheCow,
robertgshaw2-redhat,
anmarques and
Satrat
and removed request for
a team,
DaltheCow and
robertgshaw2-redhat
…sparseml into abhinav/histogram_quantizer
Satrat
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds support for utilizing HistogramObserver from PyTorch which computes the min/max values for quantization by minimizing quantization error.
The implementation has been tested on CodeLlama and Llama-2 models.