Refactoring decoders/search_strategies #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 10, 2019 16:40
… computing the full log prob distribution
added 4 commits
January 23, 2019 11:55
…may be introduced due to differences in dy.log_softmax and dy.pickneglogsoftmax
…tting attention along with context
|
Hey @armatthews I am not sure if we can also remove the attention_vecs from the attender? I think I was the one who added that and the purpose is to get the last attention score or be used somewhere. As you said, it is better to make these components stateless. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors decoders and search_strategies to use new interface calls best_k() and/or sample() instead of relying on the existence of a decoder.calc_log_probs() function.
For certain types of decoders computing the whole (log) distribution is computationally difficult or down right impossible. For example, hierarchical softmax, my morphological stuff, or the RNNG decoder with it's structured output actions.