Fixed Reporting #541
Merged
Fixed Reporting #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 metric to calculate segmentation F-measure. |
|
Any comment @msperber? |
|
I've been a bit busy, but I will take a look within the next days! |
msperber
requested changes
Nov 9, 2018
|
I have reflected all the comments, now I am merging. Thanks, @msperber ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed reporting so that compute_report is determined if there is a reporter being defined, rather than making a separate flag in exp_global. The fix includes if there are multiples eval_tasks that want to write reports to different places.
Having compute_report on exp_global is somewhat confusing, and the report should just be computed as needed (if the Reporter is defined).