-
-
Notifications
You must be signed in to change notification settings - Fork 382
WIP: Support for Voltronic Axpert P30 protocol inverters (main) #1407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Adds support for the Voltronic Axpert inverters based on the P30 protocol. Updated the nutdrv_qx driver to support the optional sending of commands protected by CRC. Initial support for query commands. Based on work done in the Voltronic Sunny driver in https://github.com/nickma82/nut/tree/nutdrv_qx_voltronic-sunny_rebased+command Still TODO: Implement commands to write to the inverter. Remove commented code originating from sunny driver. Further testing. Update docs (manpages, acknowledgements...)
This pull request introduces 1 alert when merging 5375524 into 9cb8de6 - view on LGTM.com new alerts:
|
Comparison between byte of type unsigned short and len of wider type size_t
@minfrin : I marked the PR as draft for now, so it would not burden CI with failing code to build ephemeral merges as master branch marches on. Feel free to un-set draft mode when needed to test fixes to broken builds. |
Thanks for this. All the parameters being read are working well, and it's doing the job. Testing the write functions is tricky, as the inverter is powering the machine it was developed on, so options are limited. Lining up a time to do safe testing. |
Cheers! Wondering if you have any updates on this? :) |
Resyncing with main NUT code base after v2.8.3 release. |
❌ Build nut 2.8.3.3052-master failed (commit 840d782003 by @jimklimov) |
…ck along the way [networkupstools#1407] Signed-off-by: Jim Klimov <[email protected]>
…nity-check along the way [networkupstools#1407] Signed-off-by: Jim Klimov <[email protected]>
…n arg vs. strlen(cmd) content [networkupstools#1407] Signed-off-by: Jim Klimov <[email protected]>
…tworkupstools#1407] Signed-off-by: Jim Klimov <[email protected]>
Signed-off-by: Jim Klimov <[email protected]>
…n) in some methods [networkupstools#1407] Signed-off-by: Jim Klimov <[email protected]>
…e NUT_UNUSED_VARIABLE(item) [networkupstools#1407] Signed-off-by: Jim Klimov <[email protected]>
…etworkupstools#1407] Signed-off-by: Jim Klimov <[email protected]>
networkupstools#1407] Signed-off-by: Jim Klimov <[email protected]>
…it [networkupstools#1407] Signed-off-by: Jim Klimov <[email protected]>
…and float [networkupstools#1407] Signed-off-by: Jim Klimov <[email protected]>
…o check dynamic formating string sanity at run-time [networkupstools#1407] Signed-off-by: Jim Klimov <[email protected]>
…#1407] Signed-off-by: Jim Klimov <[email protected]>
Signed-off-by: Jim Klimov <[email protected]>
…oggle Signed-off-by: Jim Klimov <[email protected]>
…and commands (and their processing methods) better than "#if 0" [networkupstools#1407] Signed-off-by: Jim Klimov <[email protected]>
… the mapping table as such; comment a few of them [networkupstools#1407] Signed-off-by: Jim Klimov <[email protected]>
…tools#1407] Signed-off-by: Jim Klimov <[email protected]>
Proposed a |
…etermined Signed-off-by: Jim Klimov <[email protected]>
…trs in git Signed-off-by: Jim Klimov <[email protected]>
…workupstools#1407] Signed-off-by: Jim Klimov <[email protected]>
…ING_AXPERT* macros [networkupstools#1407] Signed-off-by: Jim Klimov <[email protected]>
…PERT* macro definitions for better visibility [networkupstools#1407] Signed-off-by: Jim Klimov <[email protected]>
…arm[LARGEBUF] so that item->value[SMALLBUF] can fit with added markup [networkupstools#1407] ...not that we expect problems with this, but compiler warns they are feasible: error: '%s' directive output may be truncated writing up to 511 bytes into a region of size 497 [-Werror=format-truncation=] Signed-off-by: Jim Klimov <[email protected]>
…rkupstools#1407] Signed-off-by: Jim Klimov <[email protected]>
acc342f
to
002cd75
Compare
…workupstools#1407] Signed-off-by: Jim Klimov <[email protected]>
…art) [networkupstools#1407] Signed-off-by: Jim Klimov <[email protected]>
networkupstools#1407] Help with ChangeLog entry for an old URL buried in commit message years ago, from a branch getting merged just now. Signed-off-by: Jim Klimov <[email protected]>
@minfrin : I've updated this PR branch to the extent that I think the code is mergeable "quality-wise": there are changes to news and man pages, the questionable data points and related methods are hidden with In your original post you've had plans for further work, and named this PR as a "WIP"... do you have any reservations (like this code is only a boilerplate and not really functional with the devices), or can it be merged as it is now and continued in later PRs? Do you see yourself doing that in short term, BTW? :) |
…rkupstools#1407] Signed-off-by: Jim Klimov <[email protected]>
…workupstools#1407] Signed-off-by: Jim Klimov <[email protected]>
networkupstools#1407] Help with ChangeLog entry for an old URL buried in commit message years ago, from a branch getting merged just now. Signed-off-by: Jim Klimov <[email protected]>
Adds support for the Voltronic Axpert inverters based on the P30 protocol.
Updated the nutdrv_qx driver to support the optional sending of commands
protected by CRC.
Initial support for query commands. Based on work done in the Voltronic
Sunny driver in https://github.com/nickma82/nut/tree/nutdrv_qx_voltronic-sunny_rebased+command
Still TODO:
Implement commands to write to the inverter.
Remove commented code originating from sunny driver.
Further testing.
Update docs (manpages, acknowledgements,
NEWS.adoc
...)