Assume Unix path separators by default #85
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of doing nothing, fall back to Unix-style if no known definition is found so that new platforms are more likely to work by default. Some operating systems like Haiku use Unix path separators but don't define the __unix__ preprocessor directive.
|
I'm a bit concerned about this, since who knows what kind of weird platforms might break from this. |
|
Sorry I forgot about this. I understand your concern about changing the behavior without knowing what effect it might have on other platforms. If you'd prefer I could make another request to just add the |
|
Closing this as the Haiku fix was added in af0430f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current path separator code causes compilation failures in Haiku, which uses Unix-style path separators but doesn't define the
__unix__macro. Instead of just adding__HAIKU__, this makes Unix-style the default fallback since the majority of platforms use it and the previous fallback would never work correctly anyway.