Add a check-dhcp4 optional binary

[fmartinsons]

This tool is a standalone binary that can use to check if a DHCP server is "alive", it simply broadcast a DHCP DISCOVER request and listen for an OFFER or timed out.
It doesn't accept the lease offered by the server.

This can be useful to check if a DHCP server is responsive before waiting for the future lease renew, it can be part of a monitoring tool which watch some IT infrastructure. For example NAGIOS has something similar as a plugin (see https://nagios-plugins.org/doc/man/check_dhcp.html)

Originate from https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1619 where it has been advised to move this new binary into n-dhcp4 project

[fmartinsons]

Don't know why the CI is failing and don't know how to relaunch it. Someone can help here please ?

[thom311]

Don't know why the CI is failing and don't know how to relaunch it. Someone can help here please ?

The CI failure is unrelated to your branch. It's not your responsibility to fix it :) (unless you wish to send a patch).
In this case, you can ignore it. Sorry about that...

[fmartinsons]

The CI failure is unrelated to your branch. It's not your responsibility to fix it :) (unless you wish to send a patch).
In this case, you can ignore it. Sorry about that...

Ok I understand, but if I would like to help if I can, I try to reproduce the steps that I think the CI do and was unable to have the failure locally. Maybe it is a problem of gitconfig for submodules checkout ?
Do you have any ideas on what happen and how can I investigate (i.e. reproduce) on my side ?

[fmartinsons]

Hello there,

nearly two months have passed since my last comment, any chance this is going to be merged or should I considered this project to be down, if so i'll simply carry my patch forever !
I want to say that would be perfectly understandable for open source project (not having time to look at) but I just want to know if there is a slight chance for this patch to be merged or not.

[dvdhrm]

Hi @fmartinsons! You use the public API of n-dhcp4, without relying on any internal bits. Can you elaborate why you want to ship it as part of the library? Why does it need to be bundled with the library, rather than shipped as its own project that depends on n-dhcp4?

[fmartinsons]

Hi @fmartinsons! You use the public API of n-dhcp4, without relying on any internal bits. Can you elaborate why you want to ship it as part of the library? Why does it need to be bundled with the library, rather than shipped as its own project that depends on n-dhcp4?

Hello @dvdhrm , this was first submitted on NetworkManager project as you may see in the first comment , and I've been told that it would be better to put it here, which I had agreed.

I think a little binary which show up an example of usage of the library is fine (and desirable) to have in this repo. Do you see any issue of hosting this code here ? if so, no problem, I'll simply close the merge request, I just thought that it could be useful for anyone who like to use n-dhcp4 .

[dvdhrm]

I think a little binary which show up an example of usage of the library is fine (and desirable) to have in this repo. Do you see any issue of hosting this code here ? if so, no problem, I'll simply close the merge request, I just thought that it could be useful for anyone who like to use n-dhcp4 .

I don't mind examples. But you marked this as tool, and you also marked it as install=true if the config-option is specified.

[fmartinsons]

I think a little binary which show up an example of usage of the library is fine (and desirable) to have in this repo. Do you see any issue of hosting this code here ? if so, no problem, I'll simply close the merge request, I just thought that it could be useful for anyone who like to use n-dhcp4 .

I don't mind examples. But you marked this as tool, and you also marked it as install=true if the config-option is specified.

It will not be install by default though (check_dhcp4 meson option is false by default), do you have a suggestion on how make this better ? Is renaming tool by example would be more accurate ?