Skip to content

n-acd: fix constants from the RFC #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

n-acd: fix constants from the RFC #12

wants to merge 1 commit into from

Conversation

bengal
Copy link
Contributor

@bengal bengal commented Apr 9, 2025

Fix the following constants from RFC 5227:

  • PROBE_MAX is 2 seconds instead of 3
  • ANNOUNCE_NUM is 2 instead of 3

Therefore, the maximum timeout for the probe is 7 seconds instead of 9. Also update the related constants.

@bengal
n-acd: fix constants from the RFC
8a2f770 
Fix the following constants from RFC 5227:

 - PROBE_MAX is 2 seconds instead of 3
 - ANNOUNCE_NUM is 2 instead of 3

Therefore, the maximum timeout for the probe is 7 seconds instead of
9. Also update the related constants.
dvdhrm
dvdhrm approved these changes Apr 25, 2025
View reviewed changes
Copy link
Member

@dvdhrm dvdhrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did we get this wrong? Ugh! This is obviously correct, and it also matches what ipv4acd.c does in libsystemd-network (which kinda inspired this code).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvdhrm dvdhrm dvdhrm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bengal @dvdhrm