Support IPv6 validation #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not to generate the first URL for Homepage: default
$router->addRoute('/foo', [
'presenter' => 'Homepage',
'action' => 'default',
'week' => 'upcoming',
]);
$router->addRoute('/', 'Homepage:default');
|
Miloši, nejsem úplně šťastný z toho, že tu vytváříš, zavíráš a pak opakovaně vytváříš PR. Ty staré totiž nejdou smazat zhoršuje se hledání a tak. Pokud chceš přepsat kód, použij force push, ale prosím nevytvářej nové PR |
|
@dg to se omlouvám a už si dám pozor, chtěl jsem to právě udělat tak, aby v historii nic nezůstalo, ale nepovedlo se :( |
dg
force-pushed
the
master
branch
2 times, most recently
from
1a289ac to
eb30925
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IPv6 becomes more and more popular and should be supported in all corresponding parts of Nette Framework. Suggested php function filter_var($ip, FILTER_VALIDATE_IP) validates perfectly both IPv4 and IPv6