Skip to content

Component::error() returns never #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Component::error() returns never #356

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Application/UI/Component.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
$throw = func_get_arg(0);
}

return $this->lookup(Presenter::class, throw: $throw ?? true);

Check failure on line 45 in src/Application/UI/Component.php

View workflow job for this annotation

GitHub Actions / PHPStan 

Method Nette\Application\UI\Component::getPresenter() should return Nette\Application\UI\Presenter|null but returns Nette\ComponentModel\IComponent|null.
}


Expand Down Expand Up @@ -382,7 +382,7 @@
* Throws HTTP error.
* @throws Nette\Application\BadRequestException
*/
public function error(string $message = '', int $httpCode = Nette\Http\IResponse::S404_NotFound): void
public function error(string $message = '', int $httpCode = Nette\Http\IResponse::S404_NotFound): never
{
throw new Nette\Application\BadRequestException($message, $httpCode);
}
Expand Down
Loading