Skip to content

LinkGenerator: accept classname in $dest #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 22 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions .github/ISSUE_TEMPLATE/Bug_report.md

This file was deleted.

9 changes: 0 additions & 9 deletions .github/ISSUE_TEMPLATE/Feature_request.md

This file was deleted.

12 changes: 0 additions & 12 deletions .github/ISSUE_TEMPLATE/Support_question.md

This file was deleted.

21 changes: 0 additions & 21 deletions .github/ISSUE_TEMPLATE/Support_us.md

This file was deleted.

2 changes: 0 additions & 2 deletions .github/funding.yml

This file was deleted.

11 changes: 0 additions & 11 deletions .github/pull_request_template.md

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/coding-style.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
- uses: actions/checkout@v2
- uses: shivammathur/setup-php@v2
with:
php-version: 7.2
php-version: 8.0
coverage: none

- run: composer create-project nette/code-checker temp/code-checker ^3 --no-progress
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/static-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- uses: actions/checkout@v2
- uses: shivammathur/setup-php@v2
with:
php-version: 7.4
php-version: 8.0
coverage: none

- run: composer install --no-progress --prefer-dist
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
php: ['7.2', '7.3', '7.4', '8.0', '8.1']
php: ['8.0', '8.1']

fail-fast: false

Expand Down Expand Up @@ -35,7 +35,7 @@ jobs:
- uses: actions/checkout@v2
- uses: shivammathur/setup-php@v2
with:
php-version: 7.2
php-version: 8.0
coverage: none

- run: composer update --no-progress --prefer-dist --prefer-lowest --prefer-stable
Expand All @@ -49,7 +49,7 @@ jobs:
- uses: actions/checkout@v2
- uses: shivammathur/setup-php@v2
with:
php-version: 7.4
php-version: 8.0
coverage: none

- run: composer install --no-progress --prefer-dist
Expand Down
26 changes: 13 additions & 13 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,25 +15,25 @@
}
],
"require": {
"php": ">=7.2",
"nette/component-model": "^3.0",
"nette/http": "^3.0.2",
"nette/routing": "^3.0.2",
"nette/utils": "^3.2.1"
"php": ">=8.0 <8.2",
"nette/component-model": "^4.0",
"nette/http": "^4.0",
"nette/routing": "^4.0",
"nette/utils": "^3.2.1 || ^4.0"
},
"suggest": {
"nette/forms": "Allows to use Nette\\Application\\UI\\Form",
"latte/latte": "Allows using Latte in templates"
},
"require-dev": {
"nette/tester": "^2.3.1",
"nette/di": "^v3.0",
"nette/forms": "^3.0",
"nette/robot-loader": "^3.2",
"nette/security": "^3.0",
"nette/tester": "^2.4",
"nette/di": "^v4.0",
"nette/forms": "^4.0",
"nette/robot-loader": "^3.2 || ^4.0",
"nette/security": "^4.0",
"latte/latte": "^2.10.2",
"tracy/tracy": "^2.6",
"mockery/mockery": "^1.0",
"tracy/tracy": "^2.8",
"mockery/mockery": "^1.4",
"phpstan/phpstan-nette": "^0.12"
},
"conflict": {
Expand All @@ -54,7 +54,7 @@
},
"extra": {
"branch-alias": {
"dev-master": "3.1-dev"
"dev-master": "4.0-dev"
}
}
}
33 changes: 0 additions & 33 deletions contributing.md

This file was deleted.

33 changes: 13 additions & 20 deletions src/Application/Application.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,12 @@ class Application
{
use Nette\SmartObject;

/** @var int */
public $maxLoop = 20;
public int $maxLoop = 20;

/** @var bool enable fault barrier? */
public $catchExceptions;
/** enable fault barrier? */
public bool $catchExceptions = false;

/** @var string|null */
public $errorPresenter;
public ?string $errorPresenter = null;

/** @var array<callable(self): void> Occurs before the application loads presenter */
public $onStartup = [];
Expand All @@ -49,29 +47,24 @@ class Application
public $onError = [];

/** @var Request[] */
private $requests = [];
private array $requests = [];

/** @var IPresenter|null */
private $presenter;
private ?IPresenter $presenter = null;

/** @var Nette\Http\IRequest */
private $httpRequest;
private Nette\Http\IRequest $httpRequest;

/** @var Nette\Http\IResponse */
private $httpResponse;
private Nette\Http\IResponse $httpResponse;

/** @var IPresenterFactory */
private $presenterFactory;
private IPresenterFactory $presenterFactory;

/** @var Router */
private $router;
private Router $router;


public function __construct(
IPresenterFactory $presenterFactory,
Router $router,
Nette\Http\IRequest $httpRequest,
Nette\Http\IResponse $httpResponse
Nette\Http\IResponse $httpResponse,
) {
$this->httpRequest = $httpRequest;
$this->httpResponse = $httpResponse;
Expand Down Expand Up @@ -117,7 +110,7 @@ public function createInitialRequest(): Request
throw new BadRequestException('No route for HTTP request.');
} elseif (!is_string($presenter)) {
throw new Nette\InvalidStateException('Missing presenter in route definition.');
} elseif (Nette\Utils\Strings::startsWith($presenter, 'Nette:') && $presenter !== 'Nette:Micro') {
} elseif (str_starts_with($presenter, 'Nette:') && $presenter !== 'Nette:Micro') {
throw new BadRequestException('Invalid request. Presenter is not achievable.');
}

Expand All @@ -128,7 +121,7 @@ public function createInitialRequest(): Request
$params,
$this->httpRequest->getPost(),
$this->httpRequest->getFiles(),
[Request::SECURED => $this->httpRequest->isSecured()]
[Request::SECURED => $this->httpRequest->isSecured()],
);
}

Expand Down
10 changes: 3 additions & 7 deletions src/Application/ErrorPresenter.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,9 @@ final class ErrorPresenter implements Application\IPresenter
{
use Nette\SmartObject;

/** @var ILogger|null */
private $logger;


public function __construct(ILogger $logger = null)
{
$this->logger = $logger;
public function __construct(
private ?ILogger $logger = null,
) {
}


Expand Down
32 changes: 13 additions & 19 deletions src/Application/LinkGenerator.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,32 +21,26 @@ final class LinkGenerator
{
use Nette\SmartObject;

/** @var Router */
private $router;

/** @var UrlScript */
private $refUrl;

/** @var IPresenterFactory|null */
private $presenterFactory;


public function __construct(Router $router, UrlScript $refUrl, IPresenterFactory $presenterFactory = null)
{
$this->router = $router;
$this->refUrl = $refUrl;
$this->presenterFactory = $presenterFactory;
public function __construct(
private Router $router,
private UrlScript $refUrl,
private ?IPresenterFactory $presenterFactory = null,
) {
}


/**
* Generates URL to presenter.
* @param string $dest in format "[[[module:]presenter:]action] [#fragment]"
* @param string $dest in format "[[[module:]presenter:]action] [#fragment]" or "[[Class\Name:]action] [#fragment]"
* @throws UI\InvalidLinkException
*/
public function link(string $dest, array $params = []): string
{
if (!preg_match('~^([\w:]+):(\w*+)(#.*)?()$~D', $dest, $m)) {
if (!preg_match('~^([\w:]+):(\w*+)(#.*)?()$~D', $dest, $m)
&& !preg_match('~^([\\\]?\w+(?:[\\\]{1}\w+)+):(\w*+)(#.*)?()$~D', $dest, $m)
) {
throw new UI\InvalidLinkException("Invalid link destination '$dest'.");
}
throw new UI\InvalidLinkException("Invalid link destination '$dest'.");
}
[, $presenter, $action, $frag] = $m;
Expand Down Expand Up @@ -93,12 +87,12 @@ public function link(string $dest, array $params = []): string
}


public function withReferenceUrl(string $url): self
public function withReferenceUrl(string $url): static
{
return new self(
$this->router,
new UrlScript($url),
$this->presenterFactory
$this->presenterFactory,
);
}
}
21 changes: 4 additions & 17 deletions src/Application/MicroPresenter.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,27 +24,14 @@ final class MicroPresenter implements Application\IPresenter
{
use Nette\SmartObject;

/** @var Nette\DI\Container|null */
private $context;

/** @var Nette\Http\IRequest|null */
private $httpRequest;

/** @var Router|null */
private $router;

/** @var Application\Request|null */
private $request;
private ?Application\Request $request;


public function __construct(
Nette\DI\Container $context = null,
Http\IRequest $httpRequest = null,
Router $router = null
private ?Nette\DI\Container $context = null,
private ?Nette\Http\IRequest $httpRequest = null,
private ?Router $router = null,
) {
$this->context = $context;
$this->httpRequest = $httpRequest;
$this->router = $router;
}


Expand Down
Loading