Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve right prompt #8

Merged
merged 3 commits into from
Oct 4, 2019

Conversation

phra
Copy link
Contributor

@phra phra commented May 2, 2018

i made some small improvements to the right prompt of lambda theme and i would like to merge them to the main repository.

  1. print green exit status if 0
  2. print and format $CMD_DURATION

image

fixes #9

@phra
Copy link
Contributor Author

phra commented Jun 8, 2018

@hasanozgan any update?

@js402882
Copy link
Contributor

I have visually more subtle and much simpler implementation for $CMD_DURATION display (basically no more than 1 one-liner). If there would be response and interest from @hasanozgan I can prepare merge request for it.

image

@phra
Copy link
Contributor Author

phra commented Sep 28, 2018

@js402882 i can give you access to my fork to update this PR if you want.

@phra
Copy link
Contributor Author

phra commented Jan 2, 2019

@hasanozgan @js402882 is anyone alive guys?

@netologist netologist merged commit 3072990 into netologist:master Oct 4, 2019
@faogustavo
Copy link

@phra @hasanozgan I'm facing some problems with these changes.
After taking a look at the code I discovered that the problem is in the line 16.
The math done in this line, shows me an error message like this:

0.000001: value not completely converted

After commenting this line, everything works properly.

image

My setup is:

  • OS: Linux (Debian 10 - but had the same problem on ubuntu 19.04 and 19.10)
  • KDE IDE
  • Using Hyper or Konsole

@alonsodomin
Copy link

Same happens in MacOS, there is a fix in #12.

To be honest, this should have never been merged, there is little value in the additional $CMD_DURATION info in the prompt and because of poor testing, it broke a perfectly working prompt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

print and format $CMD_DURATION in right prompt
5 participants