Prepare 1.9.1

[jotak]

Description

Prepare 1.9.1:

• NETOBSERV-2307 / NETOBSERV-2315 / NETOBSERV-2307: NETOBSERV-2315: fix several IPFIX issues #1019

Also added for conflict mitigation:

• Expose goflow2 workers and sockets config #969 (no downstream impact)
• Fix decode TCP flags with u32 #968 (no downstream impact)
• Implement more format on Loki writer #970 (no downstream impact)

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

To run a perfscale test, comment with: /test flp-node-density-heavy-25nodes

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ronensc for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Attention: Patch coverage is 36.13139% with 175 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-1.9@bd115ad). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
pkg/pipeline/write/write_ipfix.go	0.00%	106 Missing ⚠️
pkg/pipeline/ingest/ingest_ipfix.go	46.29%	26 Missing and 3 partials ⚠️
pkg/pipeline/write/write_stdout.go	54.54%	15 Missing ⚠️
pkg/utils/tcp_flags.go	46.15%	7 Missing ⚠️
pkg/utils/convert.go	50.00%	6 Missing ⚠️
pkg/api/ingest_ipfix.go	88.88%	2 Missing and 1 partial ⚠️
pkg/api/write_ipfix.go	0.00%	3 Missing ⚠️
pkg/config/pipeline_builder.go	57.14%	2 Missing and 1 partial ⚠️
pkg/pipeline/pipeline_builder.go	50.00%	2 Missing ⚠️
pkg/confgen/flowlogs2metrics_config.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff               @@
##             release-1.9    #1029   +/-   ##
==============================================
  Coverage               ?   65.51%           
==============================================
  Files                  ?      121           
  Lines                  ?     8899           
  Branches               ?        0           
==============================================
  Hits                   ?     5830           
  Misses                 ?     2738           
  Partials               ?      331           

Flag	Coverage Δ
unittests	65.51% <36.13%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
pkg/api/write_loki.go	71.42% <100.00%> (ø)
pkg/config/config.go	65.00% <ø> (ø)
pkg/config/stage_params.go	72.22% <100.00%> (ø)
pkg/pipeline/transform/transform_network.go	68.96% <100.00%> (ø)
pkg/pipeline/write/write_loki.go	73.68% <100.00%> (ø)
pkg/test/ipfix.go	70.27% <100.00%> (ø)
pkg/confgen/flowlogs2metrics_config.go	68.00% <0.00%> (ø)
pkg/pipeline/pipeline_builder.go	63.80% <50.00%> (ø)
pkg/api/ingest_ipfix.go	88.88% <88.88%> (ø)
pkg/api/write_ipfix.go	0.00% <0.00%> (ø)
... and 6 more

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.