Skip to content

fix: support npm run dev (remix dev) and Netlify CLI #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 2, 2023
Merged

fix: support npm run dev (remix dev) and Netlify CLI #95

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b2863f4
fix: now we support npm run dev (remix dev) and netlify CLI
nickytonline Feb 27, 2023
c4f855f
chore: linked to remix config docs in config like edge template
nickytonline Feb 27, 2023
2687f2f
chore: Functions template README dev instruction updates
nickytonline Feb 27, 2023
e45fd11
chore: DX improvments for Netlify Functions template
nickytonline Feb 28, 2023
b04cccd
chore: removed unnecessary formatting of toml
nickytonline Feb 28, 2023
d932e0d
chore: added a new line
nickytonline Feb 28, 2023
acb8567
chore: added _custom_redirects only for Netlify Functions template
nickytonline Mar 1, 2023
3f76599
chore: updated Netlify Functions template README
nickytonline Mar 1, 2023
c5b842d
chore: DX improvements
nickytonline Mar 2, 2023
8f92177
Update remix.init/_app_redirects
nickytonline Mar 2, 2023
d977e56
docs: documentation improvements
nickytonline Mar 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ node_modules

/.cache
/public/build
/build
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remix dev generates these artifacts as well as those in /public/build

.env

# Local Netlify folder
Expand Down
16 changes: 11 additions & 5 deletions remix.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,16 @@
const baseConfig =
process.env.NETLIFY || process.env.NETLIFY_LOCAL
? // when running the Netify CLI or building on Netlify, we want to use
{
serverBuildTarget: "netlify",
server: "./server.js",
}
: // otherwise support running remix dev, i.e. no custom server
undefined;

/** @type {import('@remix-run/dev').AppConfig} */
module.exports = {
serverBuildTarget: "netlify",
server:
process.env.NETLIFY || process.env.NETLIFY_LOCAL
? "./server.js"
: undefined,
...baseConfig,
ignoredRouteFiles: ["**/.*"],
// appDirectory: "app",
// assetsBuildDirectory: "public/build",
Expand Down
4 changes: 4 additions & 0 deletions remix.init/netlify-toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
command = "remix build"
publish = "public"

[dev]
command = "remix watch"
port = 3000

[[redirects]]
from = "/*"
to = "/.netlify/functions/server"
Expand Down