chore: update demo site to use renderToReadableStream #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: chore
nickytonline
force-pushed
the
nickytonline/update-edge-demo-to-render-readable-stream
branch
from
1c1f714 to
cdf0ac6
Compare
nickytonline
changed the title
nickytonline
force-pushed
the
nickytonline/update-edge-demo-to-render-readable-stream
branch
from
cdf0ac6 to
1c36659
Compare
5 tasks
LekoArts
changed the title
nickytonline
changed the title
nickytonline
commented
Feb 23, 2023
| import { RemixServer } from '@remix-run/react' | ||
| import { renderToString } from 'react-dom/server' | ||
| import { renderToReadableStream } from 'react-dom/server' |
There was a problem hiding this comment.
For more about renderToReadableStream, see https://beta.reactjs.org/reference/react-dom/server/renderToReadableStream
orinokai
approved these changes
Feb 23, 2023
kodiakhq
bot
deleted the
nickytonline/update-edge-demo-to-render-readable-stream
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Tickets & Documents
Updates the Netlify Edge Functions demo site to use
renderReadableStream. I checked in with the Remix team after Wes opened #50. Most other templates for edge in the Remix repo userenderToStringbut Jacob recommended to go withrenderReadableStreaminstead ofrenderToString.Thanks again for the feedback @jacob-ebey and @wesbos!
QA Instructions, Screenshots, Recordings
The deploy preview is all green and when you open the site, it loads up.
For us to review and ship your PR efficiently, please perform the following steps:
ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a
typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)