-
Notifications
You must be signed in to change notification settings - Fork 6
[NAE-2058] Role refactor #313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/8.0.0
Are you sure you want to change the base?
Conversation
- fix file upload - fix enumeration set data deleted choices
- WIP add ValidationRunner & ValidationDelegate - implement ValidationRegistry with ValidationService - run validatioins on setDataField and finishTask - add validation process
- implement ValidationRunner on startup
- rename validation runner to validation executioner due to compilation errors - update executioner and service and its method calls - implement an example test scenario - remove original validations package, comment out original validations tests
- reimplement original validations into validation delegate - resolve possible duplicities (field - validation name, register existing validation name) - review tests - except date/datetime between, text regex
- update Importer.createPetriNet - remove unnecessary attributes in Importer - add util methods in Version - extend LinkedHashMap by UniqueKeyMap - use UniqueKeyMap in PetriNet - implement PetriNet.parentIdentifiers - add compound index in PetriNet - make PetriNet.identifier indexed - implemented tests in ImporterTest - fix PetriNetServiceTest
- add Case.parentPetriNetIdentifiers - update WorkflowServiceTest
- mark PetriNetIdentifier.identifier as indexed - fix typo in PetriNetController
- update validations regarding new petriflow schema
- generate ids for ProcessRoles on child net - update PetriNetService.deletePetriNet to delete child nets too - implement PetriNetServiceTest.deleteParentPetriNet
- fix attribute initialization in PetriNet
- fix query dsl generation - fix ImporterTest
- fix test nets - fix DataSearchRequestTest
- rework closures to methods in ValidationDelegate - update validations execution - update FieldFactory and add new classes for validations - update validation tests
- update schema and related data structure
- refactor model classes
- update validation delegate and executioner - add more tests for dynamic validations - update other tests for new validations
- update transition validation in ValidationService
- refactor executioner - update ValidationRunner: mongo search - update validation process - update tests - remove unnecessary tests
- refactor ValidationExecutioner - fix ValidationRunner predicate - add null check to ValidationService - update validation process - fields behavior, validation type field - add more validation tests
- comment outdated code for future work
- update model classes
- update field default value definition
- update system processes - update importer
- add configuration for action and function evaluation
- refactor arc factory to arc importer
- refactor process validation
- remove system identity, keep only user - update API to use only system user where it's needed - only app roles are assigned to super creator
- update tests - fix ApplicationRoleRunner according to tests
- Removed `@JsonIgnore` from `processRolePermissions` in `Case.java`. - Renamed `userId` to `assigneeId` in `TaskPair` for consistency. - Fixed incorrect method call `setUserId` to `setAssigneeId` in `Case.java`.
- add some javadoc
- move attributes and method from ProcessRole to Role - implement RoleService.findAllRoleIdsByActorAndGroups - update RBACController response type and error handling
- fix Identity.getAllActors - make AccessPermissions a wrapper class - implement CaseAuthorizationService.canView - implement RBACController.findApplicationRole - update NetgrifBasicAuthenticationProvider
- update TaskSearchService
- fix querydsl map type generation
- update TaskSearchService
- fix task search - fix UniqueKeyMapWrapper - fix AccessPermissions
- update initialization of ElasticPetriNet.initials - add check for uriNodeId in PetriNetService.importPetriNet - update attributes of PetriNetReference
- optimize CrudSystemCaseService.findAllByQuery
- implement property setting for SystemCase - introduce anonymous property flag
- implement: throw an exception on creation if the case already exists - update tests
- fix edge case in AuthorizationService - fix CaseAuthorizationService, TaskAuthorizationService according to tests - update tests
- implement data correction after group removal
- merge from NAE-1998 few core classes
- merge from NAE-1998 more classes
- fix compilation - remove some validation on process import - remove some validation in DataService - implement check in DataService.getLayouts - update TaskSearchRequest with state - fix tests
- fix tests - fix implementation according to tests
- implement mongo transactions in CrudSystemCaseService - implement mongo transactions in RegistrationService - update documentation in NaeTransaction
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Description
Long story short:
Identity
andActor
as Cases, where actor can be eitherUser
orGroup
.The documentation for the changes is not added. It will be added in another task. Some of the unit tests still fail (around
27
failures and45
errors out of467
tests). This tests are going to be resolved in another tasks.Implements NAE-2058
Dependencies
No new dependencies were introduced
Third party dependencies
No new dependencies were introduced
Blocking Pull requests
Depends on #266
How Has Been This Tested?
For the changes where implemented new unit tests. Many unit tests were updated to work with changes. Some scenarios where tested manually (f.e. database transaction failures - correct rollback, ...)
Test Configuration
Checklist: