Skip to content

[NAE-2072] Workspaces #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 16 commits into
base: release/7.0.0-rev2
Choose a base branch
from
Open

[NAE-2072] Workspaces #309

wants to merge 16 commits into from

Conversation

Kovy95
Copy link
Contributor

@Kovy95 Kovy95 commented May 21, 2025 •
edited by jira bot
Loading

Description

Implements NAE-2072

Dependencies

Third party dependencies

No new dependencies were introduced

Blocking Pull requests

<Depends on #(PR id)>/

How Has Been This Tested?

manually

Test Configuration

<Please describe configuration for tests to run if applicable, like program parameters, host OS, VM configuration etc.>

Name Tested on
OS LinuxMint 21
Runtime Java 21
Dependency Manager Maven 3.9.9
Framework version Spring Boot 3.4.4
Run parameters
Other configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes have been checked, personally or remotely, with @...
  • I have commented my code, particularly in hard-to-understand areas
  • I have resolved all conflicts with the target branch of the PR
  • I have updated and synced my code with the target branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes:
    • Lint test
    • Unit tests
    • Integration tests
  • I have checked my contribution with code analysis tools:
  • I have made corresponding changes to the documentation:
    • Developer documentation
    • User Guides
    • Migration Guides

Kovy95 and others added 14 commits April 28, 2025 12:33
@Kovy95
[NAE-2072] Workspaces
7f9fa9f 
- add workspace id to import
- add workspace to tests
@Kovy95
[NAE-2072] Workspaces
1ae3c85 
- change WorkspaceConstants to get workspace from user
@Kovy95
Merge remote-tracking branch 'origin/release/7.0.0-rev2' into NAE-2072
bb4ad49 
# Conflicts:
#	application-engine/src/main/groovy/com/netgrif/application/engine/DevConsole.groovy
#	application-engine/src/main/groovy/com/netgrif/application/engine/migration/ActionMigration.groovy
#	application-engine/src/main/groovy/com/netgrif/application/engine/startup/ImportHelper.groovy
#	application-engine/src/main/java/com/netgrif/application/engine/elastic/service/ElasticPetriNetService.java
#	application-engine/src/main/java/com/netgrif/application/engine/startup/runner/AnonymousRoleRunner.java
#	application-engine/src/main/java/com/netgrif/application/engine/startup/runner/DefaultRoleRunner.java
#	application-engine/src/main/java/com/netgrif/application/engine/startup/runner/SuperCreatorRunner.java
#	application-engine/src/main/java/com/netgrif/application/engine/workflow/service/TaskSearchService.java
#	application-engine/src/test/groovy/com/netgrif/application/engine/action/AssignActionTest.groovy
#	application-engine/src/test/groovy/com/netgrif/application/engine/action/AssignRemoveTest.groovy
#	application-engine/src/test/groovy/com/netgrif/application/engine/action/RemoveActionTest.groovy
#	application-engine/src/test/groovy/com/netgrif/application/engine/auth/AuthenticationControllerTest.groovy
#	application-engine/src/test/groovy/com/netgrif/application/engine/auth/SecurityContextTest.groovy
#	application-engine/src/test/groovy/com/netgrif/application/engine/auth/TaskAuthorizationServiceTest.groovy
#	application-engine/src/test/groovy/com/netgrif/application/engine/auth/WorkflowAuthorizationServiceTest.groovy
#	application-engine/src/test/groovy/com/netgrif/application/engine/elastic/DataSearchRequestTest.groovy
#	application-engine/src/test/groovy/com/netgrif/application/engine/elastic/ElasticSearchTest.groovy
#	application-engine/src/test/groovy/com/netgrif/application/engine/elastic/ElasticTaskTest.groovy
#	application-engine/src/test/groovy/com/netgrif/application/engine/elastic/ReindexTest.groovy
#	application-engine/src/test/groovy/com/netgrif/application/engine/importer/PredefinedRolesPermissionsTest.groovy
#	application-engine/src/test/groovy/com/netgrif/application/engine/importer/UserListTest.groovy
#	application-engine/src/test/groovy/com/netgrif/application/engine/ipc/AssignCancelFinishWithCaseTest.groovy
#	application-engine/src/test/groovy/com/netgrif/application/engine/ipc/CaseApiTest.groovy
#	application-engine/src/test/groovy/com/netgrif/application/engine/ipc/TaskApiTest.groovy
#	application-engine/src/test/groovy/com/netgrif/application/engine/pdf/service/PdfGeneratorTest.groovy
#	application-engine/src/test/groovy/com/netgrif/application/engine/petrinet/domain/ActionRefTest.groovy
#	application-engine/src/test/groovy/com/netgrif/application/engine/petrinet/domain/ArcOrderTest.groovy
#	application-engine/src/test/groovy/com/netgrif/application/engine/petrinet/domain/EventTest.groovy
#	application-engine/src/test/groovy/com/netgrif/application/engine/petrinet/domain/FunctionsTest.groovy
#	application-engine/src/test/groovy/com/netgrif/application/engine/petrinet/domain/ImporterTest.groovy
#	application-engine/src/test/groovy/com/netgrif/application/engine/petrinet/domain/PetriNetTest.groovy
#	application-engine/src/test/groovy/com/netgrif/application/engine/petrinet/domain/dataset/CaseFieldTest.groovy
#	application-engine/src/test/groovy/com/netgrif/application/engine/petrinet/domain/dataset/ChangeCasePropertyTest.groovy
#	application-engine/src/test/groovy/com/netgrif/application/engine/petrinet/domain/dataset/ChangeFieldValueInitTest.groovy
#	application-engine/src/test/groovy/com/netgrif/application/engine/petrinet/domain/dataset/ChoiceFieldTest.groovy
#	application-engine/src/test/groovy/com/netgrif/application/engine/petrinet/domain/dataset/DynamicCaseNameTest.groovy
#	application-engine/src/test/groovy/com/netgrif/application/engine/petrinet/domain/dataset/DynamicChoicesTest.groovy
#	application-engine/src/test/groovy/com/netgrif/application/engine/petrinet/domain/dataset/DynamicDefaultValueTest.groovy
#	application-engine/src/test/groovy/com/netgrif/application/engine/petrinet/domain/dataset/DynamicEnumerationTest.groovy
#	application-engine/src/test/groovy/com/netgrif/application/engine/petrinet/domain/dataset/DynamicValidationPerformanceTest.groovy
#	application-engine/src/test/groovy/com/netgrif/application/engine/petrinet/domain/dataset/DynamicValidationTest.groovy
#	application-engine/src/test/groovy/com/netgrif/application/engine/petrinet/domain/dataset/FileFieldTest.groovy
#	application-engine/src/test/groovy/com/netgrif/application/engine/petrinet/domain/dataset/FileListFieldTest.groovy
#	application-engine/src/test/groovy/com/netgrif/application/engine/petrinet/domain/dataset/MapFieldTest.groovy
#	application-engine/src/test/groovy/com/netgrif/application/engine/petrinet/domain/roles/ProcessRoleTest.groovy
#	application-engine/src/test/groovy/com/netgrif/application/engine/petrinet/web/PetriNetControllerTest.groovy
#	application-engine/src/test/java/com/netgrif/application/engine/importer/ImporterTest.java
#	application-engine/src/test/java/com/netgrif/application/engine/workflow/service/TaskServiceTest.java
#	application-engine/src/test/java/com/netgrif/application/engine/workflow/web/VariableArcsTest.java
@Kovy95
[NAE-2072] Workspaces
8c991c7 
- add changes from netgrif-modules
@Kovy95
[NAE-2072] Workspaces
7893e76 
- add context holder
- add functions for default roles
@Kovy95
Merge remote-tracking branch 'origin/NAE-2092' into NAE-2072
36c5317 
# Conflicts:
#	application-engine/src/main/groovy/com/netgrif/application/engine/petrinet/domain/dataset/logic/action/ActionDelegate.groovy
#	application-engine/src/main/groovy/com/netgrif/application/engine/petrinet/domain/dataset/logic/action/FieldActionsRunner.groovy
#	application-engine/src/main/java/com/netgrif/application/engine/auth/web/UserController.java
#	application-engine/src/main/java/com/netgrif/application/engine/auth/web/responsebodies/User.java
#	application-engine/src/main/java/com/netgrif/application/engine/startup/runner/AnonymousRoleRunner.java
#	application-engine/src/main/java/com/netgrif/application/engine/startup/runner/DefaultRoleRunner.java
#	nae-spring-core-adapter/src/main/java/com/netgrif/application/engine/adapter/spring/auth/domain/LoggedUserImpl.java
#	nae-spring-core-adapter/src/main/java/com/netgrif/application/engine/adapter/spring/petrinet/service/ProcessRoleService.java
#	nae-user-ce/src/main/java/com/netgrif/application/engine/auth/service/UserServiceImpl.java
@Kovy95
[NAE-2072] Workspaces
6b2e765 
- some rework
@Kovy95
Merge remote-tracking branch 'origin/NAE-2092' into NAE-2072
e85f26d 
# Conflicts:
#	application-engine/src/main/java/com/netgrif/application/engine/auth/web/UserController.java
#	application-engine/src/main/java/com/netgrif/application/engine/petrinet/service/PetriNetService.java
#	nae-user-common/src/main/java/com/netgrif/application/engine/auth/web/responsebodies/User.java
@renczesstefan
[NAE-2072] Workspaces
b1a5893 
- deleted commented files
@Kovy95
[NAE-2072] Workspaces
9a5ffc3 
- rweork of import default processes
@Kovy95
Merge remote-tracking branch 'origin/release/7.0.0-rev2' into NAE-2072
13f747b 
# Conflicts:
#	application-engine/src/main/java/com/netgrif/application/engine/auth/web/UserController.java
@Kovy95
[NAE-2072] Workspaces
a7d93d7 
- after merge
@Kovy95
[NAE-2072] Workspaces
cf83cf8 
- remove function
@Kovy95
[NAE-2072] Workspaces
487ac13 
- add workspaceId to actions as parameter to funcions
@Kovy95 Kovy95 self-assigned this May 21, 2025
@Kovy95 Kovy95 added breaking change Fix or feature that would cause existing functionality doesn't work as expected critical A change that is critical to a release and must not be omitted Extra Large labels May 21, 2025
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented May 21, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

renczesstefan and others added 2 commits May 22, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuplle tuplle Awaiting requested review from tuplle

@renczesstefan renczesstefan Awaiting requested review from renczesstefan

@machacjozef machacjozef Awaiting requested review from machacjozef

At least 1 approving review is required to merge this pull request.

Assignees

@Kovy95 Kovy95

Labels
breaking change Fix or feature that would cause existing functionality doesn't work as expected critical A change that is critical to a release and must not be omitted Extra Large
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kovy95 @renczesstefan