Skip to content

[NAE-2055] Rework enum registry to service registry #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 42 commits into
base: release/6.5.0
Choose a base branch
from
Open

[NAE-2055] Rework enum registry to service registry #291

wants to merge 42 commits into from

Conversation

Retoocs
Copy link
Contributor

@Retoocs Retoocs commented Feb 17, 2025 •
edited
Loading

Description

Implemented dynamic menu item view registry.

Implements NAE-2055

Dependencies

No new dependencies were introduced

Third party dependencies

No new dependencies were introduced

Blocking Pull requests

Depends on #290

How Has Been This Tested?

Manually and with unit tests

Test Configuration

Name Tested on
OS Ubuntu 24.04.1 LTS
Runtime Java 11
Dependency Manager Maven 3.6.3
Framework version Spring Boot 2.7.8
Run parameters
Other configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes have been checked, personally or remotely, with @mazarijuraj
  • I have commented my code, particularly in hard-to-understand areas
  • I have resolved all conflicts with the target branch of the PR
  • I have updated and synced my code with the target branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes:
    • Lint test
    • Unit tests
    • Integration tests
  • I have checked my contribution with code analysis tools:
  • I have made corresponding changes to the documentation:
    • Developer documentation
    • User Guides
    • Migration Guides

Retoocs and others added 30 commits January 28, 2025 10:08
@Retoocs
[NAE-2034] Otvorenie prvého viewu
d02feea 
- implement auto-select for menu items
@camperko
[NAE-2033] Úvodný dashboard
458b89e 
- create processes for managing dashboards - dashboard_management and dashboard_item
- create runner for importing dashboard management processes
@camperko
Merge remote-tracking branch 'origin/NAE-2034' into NAE-2033
c61be81
@camperko
[NAE-2033] Úvodný dashboard
8bf002e 
- added option to load icon from web (image from web)
- added option to change dashboard toolbar logo
- added option to chane appearance of dashboard toolbar
@camperko
[NAE-2033] Úvodný dashboard
c7cb0d2 
- added option to change icon and font colors in dashboard items
- fix for items ordering
@Retoocs
[NAE-2051] Implementovat moznost volby komponentu zobrazenia v menu i…
16a3cd6 
…temoch

- fix ActionDelegate.execute method
- update ActionDelegate menu item methods
- import configuration nets in FilterRunner
- implement MenuItemService with new or updated domain models
- move menu item domain models to menu package
- implement MenuItemView enum
- implement MenuItemUtils
- rename preference_item to menu_item
- add tabbed_case_view_configuration and tabbed_task_view_configuration nets
- update MenuItemApiTest according to changes
@Retoocs
[NAE-2051] Implementovat moznost volby komponentu zobrazenia v menu i…
12c6379 
…temoch

- add logging to MenuItemService
@Retoocs
[NAE-2051] Implementovat moznost volby komponentu zobrazenia v menu i…
860b0d0 
…temoch

- add or update javadoc
@Retoocs
[NAE-2051] Implement configurable view in menu items
255340f 
- add translations
@Retoocs
[NAE-2051] Implement configurable view in menu items
2bde47c 
- remove redundant MenuItemBody attribute
- update menu_item and tabbed_case_view_configuration dataGroups
@Retoocs
[NAE-2051] Implement configurable view in menu items
570a7ad 
- update MenuItemService find methods
- fix MenuItemApiTest.testDuplicateMenuItem
@Retoocs
[NAE-2051] Implement configurable view in menu items
6c71bdb 
- update MenuItemBody.setView
@camperko
[NAE-2033] Úvodný dashboard
06d484d 
- add option to change profile and login urls
@Retoocs
[NAE-2052] Integrate ticket view with menu items
a5e0350 
- implement TabbedTicketView configuration
- implement TabbedSingleTaskView configuration
- fix missing entry in ViewBody
- fix method call in tabbed_case_view_configuration
@camperko
[NAE-2033] Úvodný dashboard
1097ea3 
- change default value of login url to empty string
@camperko
[NAE-2033] Úvodný dashboard
9dc653e 
- update by PR comments
- create findCasesElastic method in ActionDelegate with default page size of 1000 items
- check duplicate ids in dashboard_item and dashboard_management in finish action
- move importProcess function into ImportHelper and clean runners
@Retoocs
[NAE-2052] Integrate ticket view with menu items
dd06c6e 
- fix setting view_configuration_type
@Retoocs
[NAE-2052] Integrate ticket view with menu items
7971f6d 
- add translations
@camperko
[NAE-2033] Úvodný dashboard
817cb99 
- documentation
@Kovy95
[NAE-2039] Search in workflow view
be3da23 
- implement basic elastic search for title and identifier to ElasticPetriNetService and implement endpoint for elastic search
@Kovy95
[NAE-2039] Search in workflow view
e3f80ab 
- remove TODO
@Retoocs
[NAE-2052] Integrate ticket view with menu items
145e3e0 
- enabled MenuItemApiTest
@camperko
[NAE-2033] Úvodný dashboard
1c16250 
- change default page size to 100 in findCasesElastic
@Kovy95
[NAE-2039] Search in workflow view
7211660 
- resolve PR comments
@Retoocs
[NAE-2052] Integrate ticket view with menu items
fa81b02 
- add MenuItemView.isPrimary attribute
- fix options initializing in configuration
@Kovy95
Merge remote-tracking branch 'origin/NAE-2051' into NAE-2054
4940da2 
# Conflicts:
#	src/main/groovy/com/netgrif/application/engine/startup/FilterRunner.groovy
@Kovy95
[NAE-2054] Release 6.5.0 CE
c550d27 
- fix after merge
@Kovy95
Merge remote-tracking branch 'origin/NAE-2039' into NAE-2054
9cebf5f
@Kovy95
Merge remote-tracking branch 'origin/NAE-2052' into NAE-2054
c47db8d
@Retoocs
[NAE-2055] Rework enum registry to service registry
32c8a4b 
- implement MenuItemViewRegistry
Retoocs and others added 11 commits February 17, 2025 11:17
@Retoocs
Revert "[NAE-2055] Rework enum registry to service registry"
56d016a 
This reverts commit 32c8a4b.
@Retoocs
[NAE-2051] Implement configurable view in menu items
afe468f 
- add map initialization in MenuItemBody
@Retoocs
Merge remote-tracking branch 'origin/NAE-2051' into NAE-2052
438bb1d
@Retoocs
[NAE-2055] Rework enum registry to service registry
0881cf9 
- implement MenuItemViewRegistry
@Kovy95
[NAE-2054] Release 6.5.0 CE
32f4c1a 
- fix  i18nfield in elasticPetriNet index
@Kovy95
Merge remote-tracking branch 'origin/NAE-2052' into NAE-2054
9606298
@Retoocs
[NAE-2054] Release 6.5.0 CE
1fa70e9 
- update FilterRunner after merge
@Retoocs
[NAE-2055] Rework enum registry to service registry
97fb697 
- add MenuItemViewRegistryRunner
- rework current implementation to use view registry
- fix MenuItemApiTest
@Retoocs
[NAE-2051] Implement configurable view in menu items
5eca9de 
- implement unregistration methods in MenuItemViewRegistry
- implement MenuItemViewRegistryTest
@Retoocs
[NAE-2055] Rework enum registry to service registry
810507d 
- add javadoc to MenuItemViewRegistry
@Retoocs
Merge remote-tracking branch 'origin/NAE-2054' into NAE-2055
bc3e5b1 
# Conflicts:
#	src/main/groovy/com/netgrif/application/engine/startup/FilterRunner.groovy
@Retoocs Retoocs added the improvement A change that improves on an existing feature label Feb 17, 2025
@Retoocs Retoocs self-assigned this Feb 17, 2025
@dpulls dpulls
Copy link

dpulls bot commented Feb 18, 2025

🎉 All dependencies have been resolved !

@Retoocs
[NAE-2055] Rework enum registry to service registry
68464fc 
- fix tests
- add logging to MenuItemViewRegistryRunner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camperko camperko Awaiting requested review from camperko

@Kovy95 Kovy95 Awaiting requested review from Kovy95

@SamuelPalaj SamuelPalaj Awaiting requested review from SamuelPalaj

@MartinSiran MartinSiran Awaiting requested review from MartinSiran

@mazarijuraj mazarijuraj Awaiting requested review from mazarijuraj

At least 1 approving review is required to merge this pull request.

Assignees

@Retoocs Retoocs

Labels
improvement A change that improves on an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Retoocs @camperko @Kovy95