SOW-0048: reduce rollout adapter scan/tail complexity#59
Merged
Conversation
Add deterministic scan and tail benchmarks to the adapter benchmark gate and CI benchmark inventory. Decompose scanner and tailer hot paths into focused helpers while preserving cursor, source containment, EOF finalization, and watch behavior. Track residual mapper, parser, and stream complexity in SOW-0053.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 131 |
| Duplication | 12 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 18 files
Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Summary by cubic
Reduces Codex adapter scan/tail complexity by splitting hot paths into focused helpers, and adds deterministic
Scan/Tailbenchmarks enforced in CI to guard performance.New Features
ScanandTailbenchmarks ininternal/adapters/codex/bench_test.gousing a synthetic corpus.scripts/check-bench.shand.github/workflows/ci.yml; baseline updated inbench/baseline.txt.Refactors
tailer_loop.go,tailer_events.go,tailer_watch.go, andtailer_flush.go; simplifiedtailer.go.scanner.gowith cursor normalization, resolved-root handling, and focused helpers; progress emission kept deterministic.Written for commit b84d9b3. Summary will update on new commits.