SOW-0047: reduce adapter mapper complexity#57
Merged
Conversation
Split the adapter mapper user, assistant, and snapshot paths into focused helpers while preserving event order, metadata updates, tool result payload ownership, and benchmark behavior. Add focused characterization tests for tool-result payload ownership, mixed op ordering, and snapshot metadata updates. Correct the adapter behavior spec for historical assistant op ordering and record validation/review convergence in the SOW.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 75 |
| Duplication | 1 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Summary by cubic
Reduced complexity in the
internal/adapters/claude_codemapper by splitting user, assistant, and snapshot mapping into focused helpers while keeping behavior, event order, and performance unchanged. Added characterization tests and corrected the adapter spec to reflect the historical assistant op ordering.ops_user.go,ops_assistant.go, andops_snapshot.gowith focused helpers; trimmedops.go.thinkingops → alltool_useops; kept tool-result finalization and payload ref ownership (one ref per record on the first match).tool_useassessionops withtoolUseIdstashed and child-session linking unchanged..agents/sow/specs/adapter-claude-code.mdto document the real ordering; no API/schema/runtime changes; benchmarks unchanged.Written for commit 3396721. Summary will update on new commits.