Closes #18658: Add start on boot field to VirtualMachine model #20751
Conversation
…ine model, fixed identation
|
For reviewers I had doubts about how I would do the displaying of the start on boot status. The 'status' field in the model VirtualMachine uses a badge. I decided to not use a badge but plaintext or a placeholder when the 'start_on_boot' field is empty. This was a personal choice but can be changed ofc. I did specify colors in the choices model for when a badge is preferred. I took inspiration from another merge request that added a status field to some model, so I guess I got everything covered, bulk_imports, csv_imports, etc. I added this to the tests too and they run succesfully. |
jnovinger
requested review from
a team and
arthanson
and removed request for
a team
arthanson
left a comment
arthanson
left a comment
There was a problem hiding this comment.
Good work, just some cleanup needed mostly on the color and merge the migrations together.
| @@ -0,0 +1,18 @@ | |||
| # Generated by Django 5.2.7 on 2025-11-05 13:45 | |||
There was a problem hiding this comment.
These migrations should be collapsed together
There was a problem hiding this comment.
I removed this migration, like you said in another feedback item there isn't really a case where the field should be empty. There is always some kind of behaviour when the hypervisor reboots
| The start on boot setting from the hypervisor. | ||
|
|
||
| !!! tip | ||
| Additional status may be defined by setting `VirtualMachine.start_on_boot` under the [`FIELD_CHOICES`](../../configuration/data-validation.md#field_choices) configuration parameter. |
| STATUS_LAST_STATE = 'laststate' | ||
|
|
||
| CHOICES = [ | ||
| (STATUS_ON, _('On'), 'green'), |
There was a problem hiding this comment.
You are defining color here but it isn't used, it is also inconsistent - in the list view it is always shown as a grey badge no matter the status, in the detail view it is shown as text. If there is a color/badge then it should be shown as such in both places.
There was a problem hiding this comment.
Fixed this by adding a get_start_on_boot_color method to VirtualMachine model.
| default=VirtualMachineStatusChoices.STATUS_ACTIVE, | ||
| verbose_name=_('status') | ||
| ) | ||
| start_on_boot = models.CharField( |
There was a problem hiding this comment.
This is assigning a default and then allowing blank=True and null=True you probably don't want the blank and null=True there, check the status field for an example. Is there a reason to have an unset state?
… fixed inconsistent diplay of start_on_boot
2 participants
Closes: #18658
Adds start on boot field to VirtualMachine model