Fixes #17405: Added plugin icon to plugin list/detail #19333
+24
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnovinger
commented
Apr 25, 2025
| @@ -75,3 +75,15 @@ span.color-label { | |||
| .btn-grey, .btn-gray { | |||
| @extend .btn-secondary; | |||
| } | |||
|
|
|||
| img.plugin-icon { | |||
| max-width: 1.4285em; | |||
There was a problem hiding this comment.
This was eye-balled (at ~9/7) so that it matched the font-size. I didn't immediately see any variables to re-use here.
jnovinger
commented
Apr 25, 2025
| // Assuming icon is black/white line art, invert it and tone down brightness | ||
| img.plugin-icon { | ||
| filter: invert(100%) brightness(80%); | ||
| } |
There was a problem hiding this comment.
Not loving this approach, unless we'll only ever accept black/white line-drawing-ish icons.
jnovinger
force-pushed
the
17405-plugin-icons
branch
from
ab6ca96 to
9173a11
Compare
jnovinger
requested review from
a team and
bctiemann
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #17405
iconURL value from the plugins catalog API