Skip to content

18334 add location, device, site to module filters #19312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

arthanson
Copy link
Collaborator

Fixes: #18334

Monosnap Modules | NetBox 2025-04-24 09-42-38

@arthanson arthanson marked this pull request as ready for review April 24, 2025 17:50
@arthanson arthanson requested review from a team and jeremystretch and removed request for a team April 24, 2025 17:50
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for the new filters. Other than that this looks good.

@arthanson arthanson requested a review from jeremystretch April 24, 2025 20:28
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, missed this earlier but if we're going to include a Region filter we should probably have one for SiteGroup as well. That said, the FR doesn't actually call for either.

@arthanson arthanson requested a review from jeremystretch April 25, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow filtering modules by device, location, tenant, or site
2 participants