modif: keep users group unless nou2f is used #6664
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmk3
changed the title
kmk3
requested changes
Feb 25, 2025
There was a problem hiding this comment.
To make hardware tokens available for ordinary users, some distributions
include a udev rule to make the corresponding entry in /dev/... available for
users belonging to a specific group.
Which group?
It would likely be better to just whitelist the group(s) if nou2f is not
used.
For example, see:
Also, does the issue still happen with
firejail-git?
northboot
force-pushed
the
master
branch
2 times, most recently
from
9ffcbfc to
aa0a69a
Compare
|
Thanks for the feedback. The group in question is "users" on Void Linux. The issue is also present on the latest build, but based on your example I've implemented a fix to keep that group: 8576b7d |
This group is used on Void Linux to enable members to access hardware tokens used for U2F.
kmk3
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make hardware tokens available for ordinary users, some distributions include a udev rule to make the corresponding entry in /dev/... available for users belonging to a specific group.
The options
norootandnogroupscurrently break this behavior.This PR implements a fix that checks whether
browser-disable-u2fis set tonoin order to disable these two options.