-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
profiles: thunderbird: fix access to wayland socket #6659
Conversation
Denying access to ${RUNUSER} (/run/user/$(id -u)) denies access to Wayland socket which results in thunderbird running under X11. whitelist-runuser-common.inc is included in firefox-common.profile, which is included by firefox.profile, which is in turn included by thunderbird.profile. But it is ignored by the thunderbird.profile. This patch removes the ignore whitelist-runuser-common.inc to allow thunderbird to access wayland sockets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this change I see less paths in ${RUNUSER}
than before (which makes
sense when using whitelisting) with the following command:
firejail --ignore='include globals.local' \
--ignore='include thunderbird.local' --profile=thunderbird \
ls -l "/run/user/$(id -u)"
Are you sure that this increases the access to the wayland socket?
Access to that socket is available by default AFAIK (see the
blacklist ${RUNUSER}/wayland-*
entry in many profiles).
Have you tested this with firejail-git and no profile modifications?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thunderbird does not use wruc for reason. If you enabled whitelist ${RUNUSER}/app/org.keepassxc.KeePassXC
or something else in your firefox-common.local, you need to ignore it in your Thunderbird.local.
I current use firejail-git without any modifications to the thunderbird.local. I have a few changes to globals.local and they are as follows:
runtime-clipboard.local
What the heck? whitelisting ${RUNUSER}/clipboard in globals.local blocks access to Here's are my local overrides: firefox-common.local
firefox.local
globals.local
runtime-clipboard.local
|
Ah i see. I have whitelisted a particular directory under ${RUNUSER} globally. That is the reason. How do I do something like that without affecting other files? I was ${RUNUSER}/clipboard to be available everywhere but not any parent directory. Do i use noblacklist? Thanks for the help. |
fix some issues with parent whitelisting dirs. netblue30/firejail#6659
fix some issues with parent whitelisting dirs. netblue30/firejail#6659
If you want to make sure all sandboxes can access
|
Denying access to
${RUNUSER}
(/run/user/$(id -u)
) denies access toWayland socket which results in thunderbird running under X11.
whitelist-runuser-common.inc is included in firefox-common.profile, which is
included by firefox.profile, which is in turn included by
thunderbird.profile. But it is ignored by the thunderbird.profile.
This patch removes the ignore whitelist-runuser-common.inc to allow
thunderbird to access wayland sockets.