Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New profile: vesktop #6654

Merged
merged 1 commit into from
Feb 21, 2025
Merged

New profile: vesktop #6654

merged 1 commit into from
Feb 21, 2025

Conversation

sudoAlphaX
Copy link
Contributor

Vesktop: a custom discord app

https://github.com/Vencord/Vesktop

@sudoAlphaX sudoAlphaX marked this pull request as ready for review February 20, 2025 18:18
@sudoAlphaX sudoAlphaX force-pushed the master branch 2 times, most recently from 528e27f to 381bd0c Compare February 21, 2025 01:50
kmk3
kmk3 reviewed Feb 21, 2025
View reviewed changes
Copy link
Collaborator

@kmk3 kmk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.

Please add the URL to the commit message as well.

Is there anything that does not work with the profile?

If it works well you can also add it to firecfg.config.

@sudoAlphaX
Copy link
Contributor Author

I do not face any problems with sandboxed vesktop.
Plugins, updater and arrpc works as expected.

@sudoAlphaX
Copy link
Contributor Author

Please add the URL to the commit message as well.

Can you please elaborate on this. I do not understand

@kmk3
Copy link
Collaborator

kmk3 commented Feb 21, 2025

Please add the URL to the commit message as well.

Can you please elaborate on this. I do not understand

You can squash the commits:

Then amend the resulting commit:

git commit --amend

And add the URL to the commit message:

New profile: vesktop

https://github.com/Vencord/Vesktop

Let me know if there are any questions or issues.

@sudoAlphaX
Copy link
Contributor Author

Done. Thanks for the guidance

@kmk3 kmk3 merged commit 82d5587 into netblue30:master Feb 21, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmk3 kmk3 kmk3 left review comments

Assignees
No one assigned
Labels
None yet
Projects
Release 0.9.74
Status: In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sudoAlphaX @kmk3