Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiles: qutebrowser: add @sound to private-etc #6648

Closed
wants to merge 1 commit into from

Conversation

amano-kenji
Copy link
Contributor

No description provided.

Copy link
Collaborator

@kmk3 kmk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @sound group is automatically included when nosound is not used:

  • // str can be NULL
    char *fs_etc_build(char *str) {
    while (etc_list[etc_cnt++]);
    etc_cnt--;
    if (!arg_nonetwork)
    etc_copy_group(&etc_group_network[0]);
    if (!arg_nosound)
    etc_copy_group(&etc_group_sound[0]);

@kmk3
Copy link
Collaborator

kmk3 commented Feb 16, 2025

But to be fair, some profiles do have @sound, so it's unclear when it's
intended to be used.

@rusty-snake Thoughts?

@rusty-snake
Copy link
Collaborator

@rusty-snake Thoughts?

No.
It is document.

@kmk3 kmk3 changed the title qutebrowser: add @sound to private-etc profiles: qutebrowser: add @sound to private-etc Feb 19, 2025
@kmk3
Copy link
Collaborator

kmk3 commented Feb 19, 2025

No. It is document.

I have no idea what you mean, can you clarify?

@rusty-snake
Copy link
Collaborator

No thought about @sound usage.

The behavior of private-etc in the absence of nosound is documented.

@kmk3
Copy link
Collaborator

kmk3 commented Feb 22, 2025

No thought about @sound usage.

The behavior of private-etc in the absence of nosound is documented.

Since it's already working as intended and it's documented, let's leave it as
is for now.

@kmk3 kmk3 closed this Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants