-
Notifications
You must be signed in to change notification settings - Fork 13
Implemented feature to add new attributes to existing Openshift allocations #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like a good feature to have. Just a question inline
2cdabf5
to
1f7348f
Compare
1f7348f
to
b82b6e9
Compare
@naved001 @knikolla This has been rebased and updated, and now has priority because the IBM Storage PR will now be built on it. |
…ations `validate_allocations` will now check if an Openshift allocation does not have a quota value set on either the Coldfront or Openshift side. In this case, it will set the default quota value for the allocation. Due to the complexity of Openstack quotas, this feature is only implemented for Openshift allocations for now.
b82b6e9
to
11587a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Some comments that don't need to be fixed now:
- I don't love that the behavior of
validate_allocations
between OpenStack and OpenShift is now different. We should try to factor out the commonalities and implement features like this in an agnostic way. - Could the
else
have been replaced with anelif
to keep the depth of the conditional statements flatter?
@knikolla Hilariously enough, @naved001 has already asked a similar question before. I'll try to refactor this code block within this year. I could use |
Ah, makes complete sense. I had a similar moment of understanding before I left on vacation, which I clearly forgot when coming back. |
Closes #200. Built on top of #201. This PR consists of the last commit.
validate_allocations
will now check if an Openshift allocation does not have a quota value set on either the Coldfront or Openshift side. In this case, it will set the default quota value for the allocation.Due to the complexity of Openstack quotas, this feature is only
implemented for Openshift allocations for now.