Allow validation of Openshift allocations when changing quotas #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In combination with changes to `coldfront-plugin-cloud` [1], a Coldfront patch is added to allow validation of Openshift allocation change requests (arc). Currently only one scenario is tested: If the acr requests for quotas below the current usage of the project, the user will be sent back to the change request form with an informative error message. This feature is possible by leveraging Django formsets and their built-in custom validation feature [2] [1] nerc-project/coldfront-plugin-cloud#208 [2] https://docs.djangoproject.com/en/5.1/topics/forms/formsets/#custom-formset-validation
QuanMPhm
force-pushed
the
138/request_redirect
branch
from
9a3b521 to
8c36a3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #138 when nerc-project/coldfront-plugin-cloud#208 is also merged. More info in the commit message.