Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add advanced quickstart example #5

Open
wants to merge 31 commits into
base: main
Choose a base branch
from

Conversation

LeoRoccoBreedt
Copy link

@LeoRoccoBreedt LeoRoccoBreedt commented Feb 25, 2025

Description

Include a summary of the changes and the related issue.

Related to: <ClickUp/JIRA task name>

Any expected test failures?


Add a [X] to relevant checklist items

❔ This change

  • adds a new feature
  • fixes breaking code
  • is cosmetic (refactoring/reformatting)

✔️ Pre-merge checklist

  • Refactored code (sourcery)
  • Tested code locally
  • Precommit installed and run before pushing changes
  • Added code to GitHub tests (notebooks, scripts)
  • Updated GitHub README
  • Updated the projects overview page on Notion

🧪 Test Configuration

  • OS: Windows
  • Python version: 3.12
  • Neptune version: 0.10.0
  • Affected libraries with version: Neptune Scale

@LeoRoccoBreedt
Copy link
Author

Google colab link needs to be updated

- Change title case to sentence case
- Simplify setup procedure
- Phrasing and formatting tweaks
- Two spaces before inline Python comments

Signed-off-by: Sabine Ståhlberg <[email protected]>
Signed-off-by: Sabine Ståhlberg <[email protected]>
Signed-off-by: Sabine Ståhlberg <[email protected]>
Signed-off-by: Sabine Ståhlberg <[email protected]>
Signed-off-by: Sabine Ståhlberg <[email protected]>
Signed-off-by: Sabine Ståhlberg <[email protected]>
@normandy7
Copy link
Contributor

Looks good enough for a v1 now 👍🏻 Pardon the commit spam; it's a bit finicky to collaborate on Jupyter notebooks without messing up the metadata.

@LeoRoccoBreedt
Copy link
Author

@normandy7 do we want to link this to a "Advanced Quickstart" example in the examples workspace?

@normandy7
Copy link
Contributor

normandy7 commented Mar 7, 2025

@normandy7 do we want to link this to a "Advanced Quickstart" example in the examples workspace?

Sure, but no need to label it as "advanced". And it can come later, so it doesn't block the publishing of this notebook.

@LeoRoccoBreedt LeoRoccoBreedt marked this pull request as ready for review March 7, 2025 12:57
@LeoRoccoBreedt LeoRoccoBreedt requested a review from a team as a code owner March 7, 2025 12:57
@SiddhantSadangi
Copy link
Member

@LeoRoccoBreedt - can you complete the pre-merge checklist?

@LeoRoccoBreedt
Copy link
Author

@SiddhantSadangi please can you review 🙏

Two things to note: 1) the Google Colab link will be updated before we merge into main and 2) the link to the runs table will also be updated to the final example project in the correct workspace before merging into main.

@normandy7
Copy link
Contributor

@LeoRoccoBreedt Please also change the folder to just quickstart, not advanced_quickstart.

@LeoRoccoBreedt
Copy link
Author

@normandy7 done ✅

normandy7
normandy7 previously approved these changes Mar 26, 2025
@SiddhantSadangi SiddhantSadangi force-pushed the lb/advanced_quickstart branch from a7b1ac2 to 4715940 Compare April 9, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants