asyncio: pipe_data_received: call _on_error #423
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`_on_stderr` does not exist.
This comment has been minimized.
This comment has been minimized.
bfredl
reviewed
Jan 15, 2020
| @@ -68,7 +68,7 @@ def pipe_connection_lost(self, fd, exc): | |||
| def pipe_data_received(self, fd, data): | |||
| """Used to signal `asyncio.SubprocessProtocol` of incoming data.""" | |||
| if fd == 2: # stderr fd number | |||
| self._on_stderr(data) | |||
| self._on_error(data) | |||
There was a problem hiding this comment.
_on_error is for a complete error message, not for streaming data. One could collect all the pieces and add the joined text in the process_exited call possibly. Or just change it to pass for now.
|
Actually at the moment, this line will be never called (until neovim's |
|
This was fixed by #543. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_on_stderrdoes not exist.(found by mypy)
I might be missing something here, and it does not appear to be covered with tests.