Reintialize page in allocNewBuffer only when buffer is returned #664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knizhnik
force-pushed
the
spgist_alloc_newbuf_fix_v17
branch
from
dd62f56 to
fa17884
Compare
dimitri
approved these changes
Jul 22, 2025
github-merge-queue bot
pushed a commit
to neondatabase/neon
that referenced
this pull request
Jul 22, 2025
## Problem See #12387 `allocNewBuffer` initialise page with zeros but not always return it because of parity checks. In case of wrong parity the page is rejected and as a result we have dirty page with zero LSN, which cause assertion failure on neon_write when page is evicted from shared buffers. ## Summary of changes Perform, page initialisation in `allocNewBuffer` only when buffer is returned (parity check is passed). Postgres PRs: neondatabase/postgres#661 neondatabase/postgres#662 neondatabase/postgres#663 neondatabase/postgres#664 --------- Co-authored-by: Konstantin Knizhnik <[email protected]> Co-authored-by: Kosntantin Knizhnik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.