Avoid swallowing errors in case of AttachmentType Serialization failure #1953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TheSilkMiner <[email protected]>
|
|
|
Technici4n
reviewed
Feb 11, 2025
src/main/java/net/neoforged/neoforge/attachment/AttachmentType.java
Outdated
Show resolved
Hide resolved
Signed-off-by: TheSilkMiner <[email protected]>
Technici4n
approved these changes
Feb 11, 2025
|
@neoforged/bots backport 1.21.1 |
|
Backporting to |
|
🚀 This PR has been released as NeoForge version |
|
@Technici4n backport to 1.21.1 failed. Click for failure reason{"message":"Invalid request.\n\nNo subschema in "anyOf" matched.\nFor 'anyOf/0', {"labels" => []} is not an array.\nFor 'anyOf/1', {"labels" => []} is not an array.\n1 item required; only 0 were supplied.","documentation_url":"https://docs.github.com/rest/issues/labels#add-labels-to-an-issue","status":"422"} |
TheSilkMiner
deleted the
enhancement/better-data-attachment-error-handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that this TODO has been here since the inception of the system, and that I've seen quite a few errors get swallowed, I figured it was time to tackle this.
The change itself is trivial, but going through
DataResult#getOrThrowrather than first obtaining theOptionaland then unconditionally unwrapping it gives us access to the error message that signals the issue within the codec, so the developer has a better idea of what's going on.It would be better if we were to somehow also be able to print the ID or some other kind of identifying info to specifically indicate which attachment is exploding, but that does not seem to be possible with the system as it is currently designed. For this reason, I decided to leave that temporarily as a further TODO for discussion.