Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport to 1.21.1: Fire TagsUpdatedEvent on the client side after joining a server #1901

Closed
wants to merge 1 commit into from
Closed

Backport to 1.21.1: Fire TagsUpdatedEvent on the client side after joining a server #1901

wants to merge 1 commit into from

Conversation

neoforged-automation[bot]
Copy link

@neoforged-automation neoforged-automation bot commented Jan 23, 2025 •
edited
Loading

Backport of #1736 to 1.21.1

Fixes #1694 on 1.21.1

@neoforged-automation neoforged-automation bot mentioned this pull request Jan 23, 2025
Merged
@neoforged-automation neoforged-automation bot added bug A bug or error networking Related to networking regression Worked previously but doesn't anymore backport Backport to an older version from a newer version 1.21.1 Targeted at Minecraft 1.21.1 labels Jan 23, 2025
@neoforged-pr-publishing
Copy link

  • Publish PR to GitHub Packages

@Matyrobbrt
Copy link
Member

After checking the code, this change is unneeded in 1.21.1, as the collectGameRegistries method fired in handleConfigurationFinished calls TagCollector#updateTags which fires the event.

@Matyrobbrt Matyrobbrt closed this Jan 23, 2025
@Matyrobbrt Matyrobbrt deleted the backport/1.21.1/1736 branch January 23, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.21.1 Targeted at Minecraft 1.21.1 backport Backport to an older version from a newer version bug A bug or error networking Related to networking regression Worked previously but doesn't anymore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Matyrobbrt