Add CraftingContext support #1181
Open
+108
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Matyrobbrt
added
enhancement
Previously we only supported the player in the get remaining items stage, this adds it to all stages of recipe evaluation and adds the Level and CraftingContainer as well.
Random832
force-pushed
the
crafting-context
branch
from
2f6e41b to
d9bc53c
Compare
| if (this.player instanceof ServerPlayer serverplayer) { | ||
| Level level = serverplayer.level(); | ||
| CraftingInput craftinginput = this.container.asCraftInput(); | ||
| + // using the player-free context here since the player won't be usable by the dispense method |
There was a problem hiding this comment.
Is this comment right? I see a serverplayer variable still being passed in. Looks the same as CraftingMenu patch
|
Would it be better to create either
If there is preference to keep the static threadlocal, for whatever reason, it should be moved to a field on |
Matyrobbrt
added
1.21.1
|
@Random832, this pull request has conflicts, please resolve them for this PR to move forward. |
|
Is this PR still active/desired or should it be closed? There's some comments still outstanding and merge conflicts that needs resolving |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we only supported the player in the get remaining items stage, this adds it to all stages of recipe evaluation and adds the Level and CraftingContainer as well. This will help in situations such as: the recipe needs to use durability from items in get remaining items; the recipe needs to distinguish between two identical inputs where one is shifted down or right in the grid; etc.