Add validation around serialization in AttachmentHolder

Signed-off-by: TheSilkMiner <[email protected]>

src/main/java/net/neoforged/neoforge/attachment/AttachmentHolder.java

@@ -121,12 +121,17 @@ public final CompoundTag serializeAttachments(HolderLookup.Provider provider) {
         CompoundTag tag = null;
         for (var entry : attachments.entrySet()) {
             var type = entry.getKey();
+            var key = NeoForgeRegistries.ATTACHMENT_TYPES.getKey(type);
             if (type.serializer != null) {
-                Tag serialized = ((IAttachmentSerializer<?, Object>) type.serializer).write(entry.getValue(), provider);
-                if (serialized != null) {
-                    if (tag == null)
-                        tag = new CompoundTag();
-                    tag.put(NeoForgeRegistries.ATTACHMENT_TYPES.getKey(type).toString(), serialized);
+                try {
+                    Tag serialized = ((IAttachmentSerializer<?, Object>) type.serializer).write(entry.getValue(), provider);
+                    if (serialized != null) {
+                        if (tag == null)
+                            tag = new CompoundTag();
+                        tag.put(key.toString(), serialized);
+                    }
+                } catch (Exception exception) {
+                    LOGGER.error("Failed to serialize data attachment {}. Skipping.", key, exception);
                 }
             }
         }

src/main/java/net/neoforged/neoforge/attachment/AttachmentType.java

@@ -217,7 +217,6 @@ public Tag write(T attachment, HolderLookup.Provider provider) {
                 }
 
                 private RuntimeException buildException(final String operation, final String error) {
-                    // TODO: Maybe find a way to let the user know *which* attachment has exploded?
                     return new IllegalStateException("Unable to " + operation + " attachment due to an internal codec error: " + error);
                 }
             });